From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Kosina <jikos@jikos.cz>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, Pavel Machek <pavel@ucw.cz>,
a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] swsusp: Do not use page flags
Date: Thu, 15 Mar 2007 15:23:28 -0700 [thread overview]
Message-ID: <20070315152328.228379db.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0703152317260.12394@twin.jikos.cz>
On Thu, 15 Mar 2007 23:19:02 +0100 (CET)
Jiri Kosina <jikos@jikos.cz> wrote:
> On Thu, 15 Mar 2007, Andrew Morton wrote:
>
> > > > And why _does_ suspend use GFP_ATOMIC all over the place?
> > > Generally, because it cannot sleep.
> > Why not?
>
> I guess it's simply beucase of kswapd being already frozen, so there is no
> chance that once GFP_KERNEL allocation goes to sleep, it is going to get
> any free pages eventually ... ?
No, things should run fine with a dead kswapd.
There are reasons why we can't call into filesystems from there, but
GFP_NOIO will ensure that and it is heaps better than GFP_ATOMIC.
next prev parent reply other threads:[~2007-03-15 22:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 21:14 [PATCH 0/3] swsusp: Stop using page flags Rafael J. Wysocki
2007-03-12 21:16 ` [PATCH 1/3] swsusp: Use inline functions for changing " Rafael J. Wysocki
2007-03-12 21:19 ` [PATCH 2/3] swsusp: Do not use " Rafael J. Wysocki
2007-03-15 19:08 ` Andrew Morton
2007-03-15 21:05 ` Rafael J. Wysocki
2007-03-15 21:29 ` Andrew Morton
2007-03-15 22:19 ` Jiri Kosina
2007-03-15 22:23 ` Andrew Morton [this message]
2007-03-16 0:01 ` Rafael J. Wysocki
2007-03-15 23:05 ` Pavel Machek
2007-03-20 0:31 ` Andrew Morton
2007-03-20 13:18 ` Pavel Machek
2007-03-20 21:18 ` Rafael J. Wysocki
2007-03-20 21:20 ` [PATCH 1/5] swsusp: Use inline functions for changing " Rafael J. Wysocki
2007-03-20 21:22 ` [PATCH 2/5] swsusp: do not use " Rafael J. Wysocki
2007-03-20 21:25 ` [PATCH 3/5] mm: remove unused " Rafael J. Wysocki
2007-03-20 21:26 ` [PATCH 4/5] swsusp: fix error paths in snapshot_open Rafael J. Wysocki
2007-03-20 22:16 ` Pavel Machek
2007-03-20 22:24 ` Rafael J. Wysocki
2007-03-20 22:24 ` Pavel Machek
2007-03-20 22:52 ` Rafael J. Wysocki
2007-03-20 21:28 ` [PATCH 5/5] swsusp: Use GFP_KERNEL for creating basic data structures Rafael J. Wysocki
2007-03-20 22:17 ` Pavel Machek
2007-03-12 21:20 ` [PATCH 3/3] mm: Remove unused page flags Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070315152328.228379db.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=jikos@jikos.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.