From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] swsusp: fix error paths in snapshot_open
Date: Tue, 20 Mar 2007 23:24:03 +0100 [thread overview]
Message-ID: <20070320222403.GQ3545@elf.ucw.cz> (raw)
In-Reply-To: <200703202324.39213.rjw@sisk.pl>
Hi!
> > > We forget to increase device_available if there's an error in
> > > snapshot_open(), so the snapshot device cannot be open at all after
> > > snapshot_open() has returned an error.
> >
> > Actually, this should go to the beggining of series, as it is
> > (non-critical) bugfix.
>
> Well, yes.
>
> I've just kept the original order. OTOH, I don't think it's as urgent as to go
> into 2.6.21 ("been there forever" kind of thing).
No, it is not urgent enough for 2.6.21... But I have secret plan...
trying to push bitmaps+non-bugfixes for swsusp to 2.6.23, and have
swsusp/s2ram stabilize during 2.6.22. Way too much stuff happened in
2.6.21 series.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2007-03-20 22:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-12 21:14 [PATCH 0/3] swsusp: Stop using page flags Rafael J. Wysocki
2007-03-12 21:16 ` [PATCH 1/3] swsusp: Use inline functions for changing " Rafael J. Wysocki
2007-03-12 21:19 ` [PATCH 2/3] swsusp: Do not use " Rafael J. Wysocki
2007-03-15 19:08 ` Andrew Morton
2007-03-15 21:05 ` Rafael J. Wysocki
2007-03-15 21:29 ` Andrew Morton
2007-03-15 22:19 ` Jiri Kosina
2007-03-15 22:23 ` Andrew Morton
2007-03-16 0:01 ` Rafael J. Wysocki
2007-03-15 23:05 ` Pavel Machek
2007-03-20 0:31 ` Andrew Morton
2007-03-20 13:18 ` Pavel Machek
2007-03-20 21:18 ` Rafael J. Wysocki
2007-03-20 21:20 ` [PATCH 1/5] swsusp: Use inline functions for changing " Rafael J. Wysocki
2007-03-20 21:22 ` [PATCH 2/5] swsusp: do not use " Rafael J. Wysocki
2007-03-20 21:25 ` [PATCH 3/5] mm: remove unused " Rafael J. Wysocki
2007-03-20 21:26 ` [PATCH 4/5] swsusp: fix error paths in snapshot_open Rafael J. Wysocki
2007-03-20 22:16 ` Pavel Machek
2007-03-20 22:24 ` Rafael J. Wysocki
2007-03-20 22:24 ` Pavel Machek [this message]
2007-03-20 22:52 ` Rafael J. Wysocki
2007-03-20 21:28 ` [PATCH 5/5] swsusp: Use GFP_KERNEL for creating basic data structures Rafael J. Wysocki
2007-03-20 22:17 ` Pavel Machek
2007-03-12 21:20 ` [PATCH 3/3] mm: Remove unused page flags Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070320222403.GQ3545@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.