SBS battery patch series

SBS battery patch series

[Lebedev, Vladimir P]

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]


Len, Alexey,

This is the final SBS driver patch series.

There are two main features:
1) Not needed I2C using is removed.
2) Common interface with CM battery driver is implemented:
	buffering, update_time parameter, etc ...

Vladimir.


[-- Attachment #2: sbs_series.mbox.gz --]
[-- Type: application/x-gzip, Size: 13136 bytes --]

Re: SBS battery patch series

[Len Brown]

On Friday 16 March 2007 22:33, Lebedev, Vladimir P wrote:
> 
> Len, Alexey,
> 
> This is the final SBS driver patch series.
> 
> There are two main features:
> 1) Not needed I2C using is removed.
> 2) Common interface with CM battery driver is implemented:
> 	buffering, update_time parameter, etc ...

Does this build in the upstream Linus tree for you?

drivers/acpi/sbs.c:188: error: field ‘update_timer’ has incomplete type
drivers/acpi/sbs.c: In function ‘acpi_sbs_update_time’:
drivers/acpi/sbs.c:1608: error: ‘jiffies’ undeclared (first use in this function)
drivers/acpi/sbs.c:1608: error: (Each undeclared identifier is reported only once
drivers/acpi/sbs.c:1608: error: for each function it appears in.)
drivers/acpi/sbs.c:1608: error: ‘HZ’ undeclared (first use in this function)
drivers/acpi/sbs.c:1612: warning: implicit declaration of function ‘add_timer’
drivers/acpi/sbs.c: In function ‘acpi_sbs_add’:
drivers/acpi/sbs.c:1698: warning: implicit declaration of function ‘init_timer’
drivers/acpi/sbs.c: In function ‘acpi_sbs_remove’:
drivers/acpi/sbs.c:1735: warning: implicit declaration of function ‘del_timer_sync’
make[1]: *** [drivers/acpi/sbs.o] Error 1


When you send the updated series, please include a
Signed-off-by: line at the end of each pach comment.

thanks,
-Len
-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: SBS battery patch series

[Lebedev, Vladimir P]

[-- Attachment #1: Type: text/plain, Size: 2645 bytes --]


Len,

The updated SBS patch series is attached.

Thanks.
Vladimir.


-----Original Message-----
From: Lebedev, Vladimir P 
Sent: Monday, March 19, 2007 5:07 PM
To: 'Len Brown'
Cc: Starikovskiy, Alexey Y
Subject: RE: SBS battery patch series


Len,

Please ignore my previous emails with SBS patch series.
I will resend updated series tonight or tomorrow.

Thanks.
Vladimir.


-----Original Message-----
From: Lebedev, Vladimir P 
Sent: Saturday, March 17, 2007 6:55 PM
To: 'Len Brown'; Starikovskiy, Alexey Y
Subject: FW: SBS battery patch series


Alex, Len,

> There are problems with email server; I am trying to resend the email.
> ...

Please:
a) Confirm that you have received this mail.
b) Confirm that compile errors are absent.

Thanks.
Vladimir.


-----Original Message-----
From: Lebedev, Vladimir P 
Sent: Saturday, March 17, 2007 5:43 PM
To: 'Len Brown'
Subject: RE: SBS battery patch series


There are problems with email server; I am trying to resend the email.

Fixed - added '#include <linux/timer.h>'

-----Original Message-----
From: Len Brown [mailto:lenb@kernel.org] 
Sent: Saturday, March 17, 2007 7:36 AM
To: Lebedev, Vladimir P
Cc: Starikovskiy, Alexey Y; linux-acpi@vger.kernel.org
Subject: Re: SBS battery patch series

On Friday 16 March 2007 22:33, Lebedev, Vladimir P wrote:
> 
> Len, Alexey,
> 
> This is the final SBS driver patch series.
> 
> There are two main features:
> 1) Not needed I2C using is removed.
> 2) Common interface with CM battery driver is implemented:
> 	buffering, update_time parameter, etc ...

Does this build in the upstream Linus tree for you?

drivers/acpi/sbs.c:188: error: field 'update_timer' has incomplete type
drivers/acpi/sbs.c: In function 'acpi_sbs_update_time':
drivers/acpi/sbs.c:1608: error: 'jiffies' undeclared (first use in this
function)
drivers/acpi/sbs.c:1608: error: (Each undeclared identifier is reported
only once
drivers/acpi/sbs.c:1608: error: for each function it appears in.)
drivers/acpi/sbs.c:1608: error: 'HZ' undeclared (first use in this
function)
drivers/acpi/sbs.c:1612: warning: implicit declaration of function
'add_timer'
drivers/acpi/sbs.c: In function 'acpi_sbs_add':
drivers/acpi/sbs.c:1698: warning: implicit declaration of function
'init_timer'
drivers/acpi/sbs.c: In function 'acpi_sbs_remove':
drivers/acpi/sbs.c:1735: warning: implicit declaration of function
'del_timer_sync'
make[1]: *** [drivers/acpi/sbs.o] Error 1


When you send the updated series, please include a
Signed-off-by: line at the end of each pach comment.

thanks,
-Len

[-- Attachment #2: sbs_series.mbox.gz --]
[-- Type: application/x-gzip, Size: 13268 bytes --]

Re: SBS battery patch series

[Len Brown]

On Monday 19 March 2007 11:22, Lebedev, Vladimir P wrote:
> 
> Len,
> 
> The updated SBS patch series is attached.

applied to acpi-test
(and i2c_ec.c and i2c_ec.h removed)

thanks,
-Len