[KJ] [PATCH] wireless: gcc attribute short form for hermes

[KJ] [PATCH] wireless: gcc attribute short form for hermes

[Charles Clément]

Hello kernel-janitors,

Changed calls in hermes driver to use the short defined gcc attribute macro.
Signed-off-by: Charles Clément <caratorn@gmail.com>

---

I would be glad to be assigned that task on the TODO list, if someone is
not currently working on it.
Thanks.


Index: linux-2.6.21-rc4/drivers/net/wireless/hermes.h
=================================--- linux-2.6.21-rc4.orig/drivers/net/wireless/hermes.h
+++ linux-2.6.21-rc4/drivers/net/wireless/hermes.h
@@ -198,7 +198,7 @@ struct hermes_tx_descriptor {
 	u8 retry_count;
 	u8 tx_rate;
 	__le16 tx_control;	
-} __attribute__ ((packed));
+} __packed;
 
 #define HERMES_TXSTAT_RETRYERR		(0x0001)
 #define HERMES_TXSTAT_AGEDERR		(0x0002)
@@ -245,7 +245,7 @@ struct hermes_tallies_frame {
 	/* Those last are probably not available in very old firmwares */
 	__le16 RxDiscards_WEPICVError;
 	__le16 RxDiscards_WEPExcluded;
-} __attribute__ ((packed));
+} __packed;
 
 /* Grabbed from wlan-ng - Thanks Mark... - Jean II
  * This is the result of a scan inquiry command */
@@ -262,7 +262,7 @@ struct prism2_scan_apinfo {
 	u8 rates[10];		/* Bit rate supported */
 	__le16 proberesp_rate;	/* Data rate of the response frame */
 	__le16 atim;		/* ATIM window time, Kus (hostscan only) */
-} __attribute__ ((packed));
+} __packed;
 
 /* Same stuff for the Lucent/Agere card.
  * Thanks to h1kari <h1kari AT dachb0den.com> - Jean II */
@@ -276,7 +276,7 @@ struct agere_scan_apinfo {
 	/* bits: 0-ess, 1-ibss, 4-privacy [wep] */
 	__le16 essid_len;	/* ESSID length */
 	u8 essid[32];		/* ESSID of the network */
-} __attribute__ ((packed));
+} __packed;
 
 /* Moustafa: Scan structure for Symbol cards */
 struct symbol_scan_apinfo {
@@ -294,7 +294,7 @@ struct symbol_scan_apinfo {
 	__le16 basic_rates;	/* Basic rates bitmask */
 	u8 unknown2[6];		/* Always FF:FF:FF:FF:00:00 */
 	u8 unknown3[8];		/* Always 0, appeared in f/w 3.91-68 */
-} __attribute__ ((packed));
+} __packed;
 
 union hermes_scan_info {
 	struct agere_scan_apinfo	a;
@@ -312,7 +312,7 @@ union hermes_scan_info {
   
 struct hermes_linkstatus {
 	__le16 linkstatus;         /* Link status */
-} __attribute__ ((packed));
+} __packed;
 
 struct hermes_response {
 	u16 status, resp0, resp1, resp2;
@@ -322,11 +322,11 @@ struct hermes_response {
 struct hermes_idstring {
 	__le16 len;
 	__le16 val[16];
-} __attribute__ ((packed));
+} __packed;
 
 struct hermes_multicast {
 	u8 addr[HERMES_MAX_MULTICAST][ETH_ALEN];
-} __attribute__ ((packed));
+} __packed;
 
 /* Timeouts */
 #define HERMES_BAP_BUSY_TIMEOUT (10000) /* In iterations of ~1us */
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] wireless: gcc attribute short form for hermes

[Charles Clément]

Hello,

I sent this first mail to the list, but had no feedback. Should I
contact anyone directly?

On Tue, Mar 20, 2007 at 03:14:58PM +0100, Charles Clément wrote:
> Hello kernel-janitors,
> 
> Changed calls in hermes driver to use the short defined gcc attribute macro.
> Signed-off-by: Charles Clément <caratorn@gmail.com>
> 
> ---
> 
> I would be glad to be assigned that task on the TODO list, if someone is
> not currently working on it.
> Thanks.
> 
> 
> Index: linux-2.6.21-rc4/drivers/net/wireless/hermes.h
> =================================> --- linux-2.6.21-rc4.orig/drivers/net/wireless/hermes.h
> +++ linux-2.6.21-rc4/drivers/net/wireless/hermes.h
> @@ -198,7 +198,7 @@ struct hermes_tx_descriptor {
>  	u8 retry_count;
>  	u8 tx_rate;
>  	__le16 tx_control;	
> -} __attribute__ ((packed));
> +} __packed;
>  
>  #define HERMES_TXSTAT_RETRYERR		(0x0001)
>  #define HERMES_TXSTAT_AGEDERR		(0x0002)
> @@ -245,7 +245,7 @@ struct hermes_tallies_frame {
>  	/* Those last are probably not available in very old firmwares */
>  	__le16 RxDiscards_WEPICVError;
>  	__le16 RxDiscards_WEPExcluded;
> -} __attribute__ ((packed));
> +} __packed;
>  
>  /* Grabbed from wlan-ng - Thanks Mark... - Jean II
>   * This is the result of a scan inquiry command */
> @@ -262,7 +262,7 @@ struct prism2_scan_apinfo {
>  	u8 rates[10];		/* Bit rate supported */
>  	__le16 proberesp_rate;	/* Data rate of the response frame */
>  	__le16 atim;		/* ATIM window time, Kus (hostscan only) */
> -} __attribute__ ((packed));
> +} __packed;
>  
>  /* Same stuff for the Lucent/Agere card.
>   * Thanks to h1kari <h1kari AT dachb0den.com> - Jean II */
> @@ -276,7 +276,7 @@ struct agere_scan_apinfo {
>  	/* bits: 0-ess, 1-ibss, 4-privacy [wep] */
>  	__le16 essid_len;	/* ESSID length */
>  	u8 essid[32];		/* ESSID of the network */
> -} __attribute__ ((packed));
> +} __packed;
>  
>  /* Moustafa: Scan structure for Symbol cards */
>  struct symbol_scan_apinfo {
> @@ -294,7 +294,7 @@ struct symbol_scan_apinfo {
>  	__le16 basic_rates;	/* Basic rates bitmask */
>  	u8 unknown2[6];		/* Always FF:FF:FF:FF:00:00 */
>  	u8 unknown3[8];		/* Always 0, appeared in f/w 3.91-68 */
> -} __attribute__ ((packed));
> +} __packed;
>  
>  union hermes_scan_info {
>  	struct agere_scan_apinfo	a;
> @@ -312,7 +312,7 @@ union hermes_scan_info {
>    
>  struct hermes_linkstatus {
>  	__le16 linkstatus;         /* Link status */
> -} __attribute__ ((packed));
> +} __packed;
>  
>  struct hermes_response {
>  	u16 status, resp0, resp1, resp2;
> @@ -322,11 +322,11 @@ struct hermes_response {
>  struct hermes_idstring {
>  	__le16 len;
>  	__le16 val[16];
> -} __attribute__ ((packed));
> +} __packed;
>  
>  struct hermes_multicast {
>  	u8 addr[HERMES_MAX_MULTICAST][ETH_ALEN];
> -} __attribute__ ((packed));
> +} __packed;
>  
>  /* Timeouts */
>  #define HERMES_BAP_BUSY_TIMEOUT (10000) /* In iterations of ~1us */
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

-- 
Charles Clément.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] wireless: gcc attribute short form for hermes

[John W. Linville]

On Thu, Mar 22, 2007 at 09:43:58AM +0100, Charles Clément wrote:
> On Tue, Mar 20, 2007 at 03:14:58PM +0100, Charles Clément wrote:
> > Hello kernel-janitors,
> > 
> > Changed calls in hermes driver to use the short defined gcc attribute macro.
> > Signed-off-by: Charles Clément <caratorn@gmail.com>
> 
> Hello,
> 
> I sent this first mail to the list, but had no feedback. Should I
> contact anyone directly?

I don't have any objection.  Do you want me to merge it?  Or just let
(who handles janitor patches now?) handle it?

John
-- 
John W. Linville
linville@tuxdriver.com
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] wireless: gcc attribute short form for hermes

[Alexey Dobriyan]

On 3/22/07, Charles Clément <caratorn@gmail.com> wrote:
> I sent this first mail to the list, but had no feedback. Should I
> contact anyone directly?

Looks like some of these packed attributes can be dropped altogether.

> On Tue, Mar 20, 2007 at 03:14:58PM +0100, Charles Clément wrote:
> > Changed calls in hermes driver to use the short defined gcc attribute
> macro.

> > --- linux-2.6.21-rc4.orig/drivers/net/wireless/hermes.h
> > +++ linux-2.6.21-rc4/drivers/net/wireless/hermes.h
> > @@ -198,7 +198,7 @@ struct hermes_tx_descriptor {
> >  	u8 retry_count;
> >  	u8 tx_rate;
> >  	__le16 tx_control;	
> > -} __attribute__ ((packed));
> > +} __packed;
> >
> >  #define HERMES_TXSTAT_RETRYERR		(0x0001)
> >  #define HERMES_TXSTAT_AGEDERR		(0x0002)
> > @@ -245,7 +245,7 @@ struct hermes_tallies_frame {
> >  	/* Those last are probably not available in very old firmwares */
> >  	__le16 RxDiscards_WEPICVError;
> >  	__le16 RxDiscards_WEPExcluded;
> > -} __attribute__ ((packed));
> > +} __packed;
> >
> >  /* Grabbed from wlan-ng - Thanks Mark... - Jean II
> >   * This is the result of a scan inquiry command */
> > @@ -262,7 +262,7 @@ struct prism2_scan_apinfo {
> >  	u8 rates[10];		/* Bit rate supported */
> >  	__le16 proberesp_rate;	/* Data rate of the response frame */
> >  	__le16 atim;		/* ATIM window time, Kus (hostscan only) */
> > -} __attribute__ ((packed));
> > +} __packed;
> >
> >  /* Same stuff for the Lucent/Agere card.
> >   * Thanks to h1kari <h1kari AT dachb0den.com> - Jean II */
> > @@ -276,7 +276,7 @@ struct agere_scan_apinfo {
> >  	/* bits: 0-ess, 1-ibss, 4-privacy [wep] */
> >  	__le16 essid_len;	/* ESSID length */
> >  	u8 essid[32];		/* ESSID of the network */
> > -} __attribute__ ((packed));
> > +} __packed;
> >
> >  /* Moustafa: Scan structure for Symbol cards */
> >  struct symbol_scan_apinfo {
> > @@ -294,7 +294,7 @@ struct symbol_scan_apinfo {
> >  	__le16 basic_rates;	/* Basic rates bitmask */
> >  	u8 unknown2[6];		/* Always FF:FF:FF:FF:00:00 */
> >  	u8 unknown3[8];		/* Always 0, appeared in f/w 3.91-68 */
> > -} __attribute__ ((packed));
> > +} __packed;
> >
> >  union hermes_scan_info {
> >  	struct agere_scan_apinfo	a;
> > @@ -312,7 +312,7 @@ union hermes_scan_info {
> >
> >  struct hermes_linkstatus {
> >  	__le16 linkstatus;         /* Link status */
> > -} __attribute__ ((packed));
> > +} __packed;
> >
> >  struct hermes_response {
> >  	u16 status, resp0, resp1, resp2;
> > @@ -322,11 +322,11 @@ struct hermes_response {
> >  struct hermes_idstring {
> >  	__le16 len;
> >  	__le16 val[16];
> > -} __attribute__ ((packed));
> > +} __packed;
> >
> >  struct hermes_multicast {
> >  	u8 addr[HERMES_MAX_MULTICAST][ETH_ALEN];
> > -} __attribute__ ((packed));
> > +} __packed;

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] wireless: gcc attribute short form for hermes

[Charles Clément]

On Thu, Mar 22, 2007 at 08:46:00AM -0400, John W. Linville wrote:
> On Thu, Mar 22, 2007 at 09:43:58AM +0100, Charles Clément wrote:
> > On Tue, Mar 20, 2007 at 03:14:58PM +0100, Charles Clément wrote:
> > > Hello kernel-janitors,
> > > 
> > > Changed calls in hermes driver to use the short defined gcc attribute macro.
> > > Signed-off-by: Charles Clément <caratorn@gmail.com>
> > 
> > Hello,
> > 
> > I sent this first mail to the list, but had no feedback. Should I
> > contact anyone directly?
> 
> I don't have any objection.  Do you want me to merge it?  Or just let
> (who handles janitor patches now?) handle it?

Thank you, I don't know who does handle the janitor patch, the
MAINTAINERS file says Several, but cite none of them.

-- 
Charles Clément.
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors