Address Parsing

Address Parsing

[Henne Vogelsang]

Hi,

i had a listmember that sent a mail that included brackets in the
address field. Something like that:

To: mmj@mmj.dk
Cc: Heino Vogel <hvogel@hennevogel.de>, opensuse-test@opensuse.org, "Henne (Work)" <hvogel@suse.de>

After some testing we found that the to/cc parsing goes wrong here
(maybe because () are illegal?). The 3. and 4. address never reach mlmmj
and thus it thinks that the listaddress (opensuse-test@opensuse.org) is
not in to or cc.

Henne 

-- 
Henne Vogelsang, Teamlead Core Services
http://www.opensuse.org

Re: Address Parsing

[Mads Martin Joergensen]

* Henne Vogelsang <hvogel@opensuse.org> [Mar 20. 2007 15:09]:
> Hi,
> 
> i had a listmember that sent a mail that included brackets in the
> address field. Something like that:
> 
> To: mmj@mmj.dk
> Cc: Heino Vogel <hvogel@hennevogel.de>, opensuse-test@opensuse.org,
> "Henne (Work)" <hvogel@suse.de>
> 
> After some testing we found that the to/cc parsing goes wrong here
> (maybe because () are illegal?). The 3. and 4. address never reach mlmmj
> and thus it thinks that the listaddress (opensuse-test@opensuse.org) is
> not in to or cc.

I just looked through find_email_address.c, and it's the same in
FreeBSD-6.2, so the error must be ours?

Neal, it's been a while, am I remembering incorrectly that you added
this code (which was a HUGE improvement still)?

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                 -- A. P. J.

Re: Address Parsing

[Morten K. Poulsen]

Hi Henne,

Henne Vogelsang <hvogel@opensuse.org> wrote:
> i had a listmember that sent a mail that included brackets in the
> address field. Something like that:
> 
> To: mmj@mmj.dk
> Cc: Heino Vogel <hvogel@hennevogel.de>, opensuse-test@opensuse.org, "Henne
> (Work)" <hvogel@suse.de>
> 
> After some testing we found that the to/cc parsing goes wrong here
> (maybe because () are illegal?). The 3. and 4. address never reach mlmmj
> and thus it thinks that the listaddress (opensuse-test@opensuse.org) is
> not in to or cc.

The parsing failed at the quotes. The code looked for end-quote, and if the
end-quote was after the comma, the comma was ignored. This should (obviously)
only be done, if the begin-quote was before the comma.

This patch fixes the issue:
http://mlmmj.mmj.dk/~mortenp/patch-mlmmj-1.2.13-find_email_adr.diff

Neale, will you send this fix upstream to wherever-the-code-came-from? :-)


Morten

-- 
Morten K. Poulsen <morten@afdelingp.dk>
http://www.afdelingp.dk/

Re: Address Parsing

[Mads Martin Joergensen]

* Morten K. Poulsen <morten@afdelingp.dk> [Mar 20. 2007 19:18]:
> This patch fixes the issue:
> http://mlmmj.mmj.dk/~mortenp/patch-mlmmj-1.2.13-find_email_adr.diff
> 
> Neale, will you send this fix upstream to wherever-the-code-came-from? :-)

Morten you can log into panther and look in /usr/src/usr.bin/mail/aux.c
:-))

FreeBSD 6.2 might have this bug as well.

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                 -- A. P. J.

Re: Address Parsing

[Neale Pickett]

On Tuesday 20 March 2007 2:17 pm, Mads Martin Joergensen wrote:
> * Morten K. Poulsen <morten@afdelingp.dk> [Mar 20. 2007 19:18]:
> > This patch fixes the issue:
> > http://mlmmj.mmj.dk/~mortenp/patch-mlmmj-1.2.13-find_email_adr.diff
> >
> > Neale, will you send this fix upstream to wherever-the-code-came-from?
> > :-)
>
> Morten you can log into panther and look in /usr/src/usr.bin/mail/aux.c

I must have unsubscribed.

You guys are awesome, you found a bug with BSD mail?  Way to go!

I have no idea whom to tell about it.  I just grabbed that code off of some 
FreeBSD ports wotzit on the web.

Re: Address Parsing

[Mads Martin Joergensen]

* Neale Pickett <neale@woozle.org> [Mar 20. 2007 21:51]:
> > * Morten K. Poulsen <morten@afdelingp.dk> [Mar 20. 2007 19:18]:
> > > This patch fixes the issue:
> > > http://mlmmj.mmj.dk/~mortenp/patch-mlmmj-1.2.13-find_email_adr.diff
> > >
> > > Neale, will you send this fix upstream to wherever-the-code-came-from?
> > > :-)
> >
> > Morten you can log into panther and look in /usr/src/usr.bin/mail/aux.c
> 
> I must have unsubscribed.
> 
> You guys are awesome, you found a bug with BSD mail?  Way to go!
> 
> I have no idea whom to tell about it.  I just grabbed that code off of some 
> FreeBSD ports wotzit on the web.

Someone needs to fire off send-pr(1) on a current FreeBSD machine.
Panther is such, but since you, Morten, have found and fixed a bug in
FreeBSD mail as Neale points out, you might want to send it yourself to
get proper credit :-)

Just type send-pr, and you should be good to go.

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                 -- A. P. J.

Re: Address Parsing

[Henne Vogelsang]

Hi,

On Tuesday, March 20, 2007 at 19:17:59, Morten K.Poulsen wrote:
> Henne Vogelsang <hvogel@opensuse.org> wrote:
> > i had a listmember that sent a mail that included brackets in the
> > address field.
> 
> The parsing failed at the quotes.
>
> This patch fixes the issue:
> http://mlmmj.mmj.dk/~mortenp/patch-mlmmj-1.2.13-find_email_adr.diff

Verified. Running on lists.opensuse.org. Thanks for fixing :)

Henne

-- 
Henne Vogelsang, Teamlead Core Services
http://www.opensuse.org

Re: Address Parsing

[Morten K. Poulsen]

Hi,

Mads Martin Joergensen <mmj@mmj.dk> wrote:
> * Neale Pickett <neale@woozle.org> [Mar 20. 2007 21:51]:
>>> Morten you can log into panther and look in
>>> /usr/src/usr.bin/mail/aux.c
[snip]
>> You guys are awesome, you found a bug with BSD mail?  Way to go!

We may be awsome ;-) But the bug I fixed is not in BSD mail. It is
only in mlmmj. It was added as a part of a fix for mlmmj-1.2.10:

 o Fix nasty bug in the new 1.2.9 find_email_adr() making comma in
   quoted text in From: being discarded as invalid

> ... since you, Morten, have found and fixed a bug in FreeBSD mail
> as Neale points out, you might want to send it yourself to get
> proper credit :-)

Well, no FreeBSD credit for me in this round  ;-)

But the bug is out of mlmmj. That's the main issue.


Morten

-- 
Morten K. Poulsen <morten@afdelingp.dk>
http://www.afdelingp.dk/