[Ocfs2-devel] [RFC: 2.6.16 patch] ocfs2 heartbeat: clean up bio submission code

[Ocfs2-devel] [RFC: 2.6.16 patch] ocfs2 heartbeat: clean up bio submission code

[Adrian Bunk]

On Mon, Mar 26, 2007 at 01:57:17PM +0200, Lars Ellenberg wrote:
> 
> uhm, how about 
> 
>   commit b559292e066f6d570cd5aa5dbd41de61dd04bdce
>   tree d8221b5f54ad9b8cef694de687013614dccf5966
>   parent 925037bcba7691db2403684141a276930ad184f3
>   author Philipp Reisner <philipp.reisner@linbit.com> Thu, 11 Jan 2007 10:58:10 +0100
>   committer Mark Fasheh <mark.fasheh@oracle.com> Wed, 07 Feb 2007 12:15:58 -0800
>   
>       [PATCH] ocfs2 heartbeat: clean up bio submission code
> 
> pretty please?

It doesn't apply without rejects and seems non-trivial.

I need a patch that:
- applies and
- was runtime tested with 2.6.16.45 and
- got approved by the OCFS2 maintainers as being low-risk.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

[Ocfs2-devel] Re: [RFC: 2.6.16 patch] ocfs2 heartbeat: clean up bio submission code

[Mark Fasheh]

On Thu, Mar 29, 2007 at 10:30:19AM +0200, Lars Ellenberg wrote:
> > - got approved by the OCFS2 maintainers as being low-risk.
> 
> ok, I'll try to adjust it anyways as soon as I find the time,
> if no one else steps forward :)
> but maybe I'll miss your .46 window :(
> you should hear from me again by saturday latest.

I'm on vacation until Sunday, so I unfortunately wouldn't be able to review
a patch until next week. In general, I'm not opposed to the concept -
I don't have much time for extra testing though, so if you could please
include detailed information on how your patch was verified to work, that
would really help me out.

Thanks,
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com

[Ocfs2-devel] Re: [RFC: 2.6.16 patch] ocfs2 heartbeat: clean up bio submission code

[Adrian Bunk]

On Thu, Mar 29, 2007 at 10:30:19AM +0200, Lars Ellenberg wrote:
> On Tue, Mar 27, 2007 at 12:34:49AM +0200, Adrian Bunk wrote:
> > On Mon, Mar 26, 2007 at 01:57:17PM +0200, Lars Ellenberg wrote:
> > > 
> > > uhm, how about 
> > > 
> > >   commit b559292e066f6d570cd5aa5dbd41de61dd04bdce
> > >   tree d8221b5f54ad9b8cef694de687013614dccf5966
> > >   parent 925037bcba7691db2403684141a276930ad184f3
> > >   author Philipp Reisner <philipp.reisner@linbit.com> Thu, 11 Jan 2007 10:58:10 +0100
> > >   committer Mark Fasheh <mark.fasheh@oracle.com> Wed, 07 Feb 2007 12:15:58 -0800
> > >   
> > >       [PATCH] ocfs2 heartbeat: clean up bio submission code
> > > 
> > > pretty please?
> > 
> > It doesn't apply without rejects and seems non-trivial.
> > 
> > I need a patch that:
> > - applies and
> > - was runtime tested with 2.6.16.45 and
> > - got approved by the OCFS2 maintainers as being low-risk.
> 
> ok, I'll try to adjust it anyways as soon as I find the time,
> if no one else steps forward :)
> but maybe I'll miss your .46 window :(
> you should hear from me again by saturday latest.

You've already missed the .46 window, but that shouldn't be a big issue 
since it could still get into .47 next week or .48 two weeks from now.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed