All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@linux-foundation.org>,
	Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
	dwmw2@infradead.org
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [-mm patch] drivers/mtd/ubi/: make code static
Date: Wed, 28 Mar 2007 14:11:41 +0200	[thread overview]
Message-ID: <20070328121141.GQ16477@stusta.de> (raw)
In-Reply-To: <20070326205706.a750bb35.akpm@linux-foundation.org>

On Mon, Mar 26, 2007 at 08:57:06PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.21-rc4-mm1:
>...
>  git-ubi.patch
>...
>  git trees
>...


This patch makes needlessly global code static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/mtd/ubi/eba.c  |    4 ++--
 drivers/mtd/ubi/vtbl.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

--- linux-2.6.21-rc5-mm2/drivers/mtd/ubi/eba.c.old	2007-03-27 23:36:48.000000000 +0200
+++ linux-2.6.21-rc5-mm2/drivers/mtd/ubi/eba.c	2007-03-27 23:38:05.000000000 +0200
@@ -489,8 +489,8 @@ out_unlock:
  * Returns new physical eraseblock number in case of success, and a negative
  * error code in case of failure.
  */
-int recover_peb(struct ubi_device *ubi, int pnum, int vol_id, int lnum,
-		const void *buf, int offset, int len)
+static int recover_peb(struct ubi_device *ubi, int pnum, int vol_id, int lnum,
+		       const void *buf, int offset, int len)
 {
 	int err, idx = vol_id2idx(ubi, vol_id), new_pnum, data_size, tries = 0;
 	struct ubi_volume *vol = ubi->volumes[idx];
--- linux-2.6.21-rc5-mm2/drivers/mtd/ubi/vtbl.c.old	2007-03-27 23:38:54.000000000 +0200
+++ linux-2.6.21-rc5-mm2/drivers/mtd/ubi/vtbl.c	2007-03-27 23:39:08.000000000 +0200
@@ -68,7 +68,7 @@ static void paranoid_vtbl_check(const st
 #endif
 
 /* Empty volume table record */
-struct ubi_vtbl_record empty_vtbl_record;
+static struct ubi_vtbl_record empty_vtbl_record;
 
 /**
  * ubi_change_vtbl_record - change volume table record.

WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@linux-foundation.org>,
	Artem Bityutskiy <Artem.Bityutskiy@nokia.com>,
	dwmw2@infradead.org
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: [-mm patch] drivers/mtd/ubi/: make code static
Date: Wed, 28 Mar 2007 14:11:41 +0200	[thread overview]
Message-ID: <20070328121141.GQ16477@stusta.de> (raw)
In-Reply-To: <20070326205706.a750bb35.akpm@linux-foundation.org>

On Mon, Mar 26, 2007 at 08:57:06PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.21-rc4-mm1:
>...
>  git-ubi.patch
>...
>  git trees
>...


This patch makes needlessly global code static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/mtd/ubi/eba.c  |    4 ++--
 drivers/mtd/ubi/vtbl.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

--- linux-2.6.21-rc5-mm2/drivers/mtd/ubi/eba.c.old	2007-03-27 23:36:48.000000000 +0200
+++ linux-2.6.21-rc5-mm2/drivers/mtd/ubi/eba.c	2007-03-27 23:38:05.000000000 +0200
@@ -489,8 +489,8 @@ out_unlock:
  * Returns new physical eraseblock number in case of success, and a negative
  * error code in case of failure.
  */
-int recover_peb(struct ubi_device *ubi, int pnum, int vol_id, int lnum,
-		const void *buf, int offset, int len)
+static int recover_peb(struct ubi_device *ubi, int pnum, int vol_id, int lnum,
+		       const void *buf, int offset, int len)
 {
 	int err, idx = vol_id2idx(ubi, vol_id), new_pnum, data_size, tries = 0;
 	struct ubi_volume *vol = ubi->volumes[idx];
--- linux-2.6.21-rc5-mm2/drivers/mtd/ubi/vtbl.c.old	2007-03-27 23:38:54.000000000 +0200
+++ linux-2.6.21-rc5-mm2/drivers/mtd/ubi/vtbl.c	2007-03-27 23:39:08.000000000 +0200
@@ -68,7 +68,7 @@ static void paranoid_vtbl_check(const st
 #endif
 
 /* Empty volume table record */
-struct ubi_vtbl_record empty_vtbl_record;
+static struct ubi_vtbl_record empty_vtbl_record;
 
 /**
  * ubi_change_vtbl_record - change volume table record.


  parent reply	other threads:[~2007-03-28 12:13 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-27  4:57 2.6.21-rc5-mm1 Andrew Morton
2007-03-27  6:20 ` 2.6.21-rc5-mm1 David Miller
2007-03-27 11:15 ` 2.6.21-rc5-mm1 Bartlomiej Zolnierkiewicz
2007-03-27 16:52 ` [-mm patch] fix arch/i386/kernel/marker.c compilation Adrian Bunk
2007-03-27 17:11   ` Mathieu Desnoyers
2007-03-27 17:29     ` Christoph Hellwig
2007-03-28 12:11     ` [-mm patch] no longer #include <asm/kdebug.h> Adrian Bunk
2007-03-27 17:39 ` 2.6.21-rc5-mm1 Badari Pulavarty
2007-03-27 16:48   ` 2.6.21-rc5-mm1 Andrew Morton
2007-03-27 17:57     ` 2.6.21-rc5-mm1 Badari Pulavarty
2007-03-27 20:12       ` 2.6.21-rc5-mm1 Andrew Morton
2007-03-27 20:30         ` 2.6.21-rc5-mm1 Eric Dumazet
2007-03-27 21:29         ` 2.6.21-rc5-mm1 Eric Dumazet
2007-03-27 21:40           ` 2.6.21-rc5-mm1 Andrew Morton
2007-03-27 23:29             ` 2.6.21-rc5-mm1 Badari Pulavarty
2007-03-27 22:15         ` 2.6.21-rc5-mm1 Badari Pulavarty
2007-03-27 17:54 ` 2.6.21-rc5-mm1 Badari Pulavarty
2007-03-27 20:28   ` 2.6.21-rc5-mm1 Andrew Morton
2007-03-27 21:23 ` 2.6.21-rc5-mm1 Sam Ravnborg
2007-03-27 21:26 ` 2.6.21-rc5-mm1: i386/x86_64 register_die_notifier() change Adrian Bunk
2007-03-27 21:29   ` [discuss] " Andi Kleen
2007-03-28 12:11 ` Adrian Bunk [this message]
2007-03-28 12:11   ` [-mm patch] drivers/mtd/ubi/: make code static Adrian Bunk
2007-03-28 12:58   ` Artem Bityutskiy
2007-03-28 12:58     ` Artem Bityutskiy
2007-03-28 16:44 ` 2.6.21-rc5-mm1 Mariusz Kozłowski
2007-03-28 19:59   ` 2.6.21-rc5-mm1 Mariusz Kozłowski
2007-03-28 20:02   ` 2.6.21-rc5-mm1 Andrew Morton
2007-03-28 20:25     ` 2.6.21-rc5-mm1 Adrian Bunk
2007-03-28 20:49       ` 2.6.21-rc5-mm1 Mariusz Kozłowski
2007-03-29 18:01         ` 2.6.21-rc5-mm1 Mariusz Kozłowski
2007-03-29 17:52           ` 2.6.21-rc5-mm1 Andrew Morton
2007-03-29 18:45             ` 2.6.21-rc5-mm1 Mariusz Kozłowski
2007-03-29 18:38               ` 2.6.21-rc5-mm1 Ingo Molnar
2007-03-29 19:02                 ` 2.6.21-rc5-mm1 Mariusz Kozłowski
2007-03-29 19:40                   ` 2.6.21-rc5-mm1 Matt Mackall
2007-03-29 18:21           ` 2.6.21-rc5-mm1 Matt Mackall
2007-03-29 18:55             ` 2.6.21-rc5-mm1 Mariusz Kozłowski
2007-03-29 19:46               ` 2.6.21-rc5-mm1 Matt Mackall
2007-03-28 20:31     ` 2.6.21-rc5-mm1 john stultz
2007-03-31  6:28       ` 2.6.21-rc5-mm1 Mariusz Kozłowski
     [not found] ` <48f7fe350703291332q5f2da2dar7c52afd34f79072a@mail.gmail.com>
2007-03-29 21:33   ` 2.6.21-rc5-mm1 Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070328121141.GQ16477@stusta.de \
    --to=bunk@stusta.de \
    --cc=Artem.Bityutskiy@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.