From: Len Brown <lenb@kernel.org>
To: akpm@linux-foundation.org
Cc: linux-acpi@vger.kernel.org, randy.dunlap@oracle.com
Subject: Re: [patch 4/4] acpi/dock: use NULL for pointer
Date: Wed, 28 Mar 2007 23:32:26 -0400 [thread overview]
Message-ID: <200703282332.26875.lenb@kernel.org> (raw)
In-Reply-To: <200703270538.l2R5cnU9007940@shell0.pdx.osdl.net>
Applied.
thanks,
-Len
On Tuesday 27 March 2007 01:38, akpm@linux-foundation.org wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Use NULL instead of 0 for pointers:
> drivers/acpi/dock.c:677:75: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/acpi/dock.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -puN drivers/acpi/dock.c~acpi-dock-use-null-for-pointer drivers/acpi/dock.c
> --- a/drivers/acpi/dock.c~acpi-dock-use-null-for-pointer
> +++ a/drivers/acpi/dock.c
> @@ -29,6 +29,7 @@
> #include <linux/notifier.h>
> #include <linux/platform_device.h>
> #include <linux/jiffies.h>
> +#include <linux/stddef.h>
> #include <acpi/acpi_bus.h>
> #include <acpi/acpi_drivers.h>
>
> @@ -674,7 +675,7 @@ static ssize_t show_dock_uid(struct devi
> struct device_attribute *attr, char *buf)
> {
> unsigned long lbuf;
> - acpi_status status = acpi_evaluate_integer(dock_station->handle, "_UID", 0, &lbuf);
> + acpi_status status = acpi_evaluate_integer(dock_station->handle, "_UID", NULL, &lbuf);
> if(ACPI_FAILURE(status)) {
> return 0;
> }
> _
>
prev parent reply other threads:[~2007-03-29 3:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-27 5:38 [patch 4/4] acpi/dock: use NULL for pointer akpm
2007-03-29 3:32 ` Len Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200703282332.26875.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.