* [patch 4/4] acpi/dock: use NULL for pointer
@ 2007-03-27 5:38 akpm
2007-03-29 3:32 ` Len Brown
0 siblings, 1 reply; 2+ messages in thread
From: akpm @ 2007-03-27 5:38 UTC (permalink / raw)
To: lenb; +Cc: linux-acpi, akpm, randy.dunlap
From: Randy Dunlap <randy.dunlap@oracle.com>
Use NULL instead of 0 for pointers:
drivers/acpi/dock.c:677:75: warning: Using plain integer as NULL pointer
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Len Brown <lenb@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/acpi/dock.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN drivers/acpi/dock.c~acpi-dock-use-null-for-pointer drivers/acpi/dock.c
--- a/drivers/acpi/dock.c~acpi-dock-use-null-for-pointer
+++ a/drivers/acpi/dock.c
@@ -29,6 +29,7 @@
#include <linux/notifier.h>
#include <linux/platform_device.h>
#include <linux/jiffies.h>
+#include <linux/stddef.h>
#include <acpi/acpi_bus.h>
#include <acpi/acpi_drivers.h>
@@ -674,7 +675,7 @@ static ssize_t show_dock_uid(struct devi
struct device_attribute *attr, char *buf)
{
unsigned long lbuf;
- acpi_status status = acpi_evaluate_integer(dock_station->handle, "_UID", 0, &lbuf);
+ acpi_status status = acpi_evaluate_integer(dock_station->handle, "_UID", NULL, &lbuf);
if(ACPI_FAILURE(status)) {
return 0;
}
_
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 4/4] acpi/dock: use NULL for pointer
2007-03-27 5:38 [patch 4/4] acpi/dock: use NULL for pointer akpm
@ 2007-03-29 3:32 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2007-03-29 3:32 UTC (permalink / raw)
To: akpm; +Cc: linux-acpi, randy.dunlap
Applied.
thanks,
-Len
On Tuesday 27 March 2007 01:38, akpm@linux-foundation.org wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> Use NULL instead of 0 for pointers:
> drivers/acpi/dock.c:677:75: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Len Brown <lenb@kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/acpi/dock.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff -puN drivers/acpi/dock.c~acpi-dock-use-null-for-pointer drivers/acpi/dock.c
> --- a/drivers/acpi/dock.c~acpi-dock-use-null-for-pointer
> +++ a/drivers/acpi/dock.c
> @@ -29,6 +29,7 @@
> #include <linux/notifier.h>
> #include <linux/platform_device.h>
> #include <linux/jiffies.h>
> +#include <linux/stddef.h>
> #include <acpi/acpi_bus.h>
> #include <acpi/acpi_drivers.h>
>
> @@ -674,7 +675,7 @@ static ssize_t show_dock_uid(struct devi
> struct device_attribute *attr, char *buf)
> {
> unsigned long lbuf;
> - acpi_status status = acpi_evaluate_integer(dock_station->handle, "_UID", 0, &lbuf);
> + acpi_status status = acpi_evaluate_integer(dock_station->handle, "_UID", NULL, &lbuf);
> if(ACPI_FAILURE(status)) {
> return 0;
> }
> _
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-03-29 3:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-27 5:38 [patch 4/4] acpi/dock: use NULL for pointer akpm
2007-03-29 3:32 ` Len Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.