Re: [PATCH] libnetfilter_conntrack: add extern C's to public headers

[Phil Dibowitz <phil@ipom.com>]

[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]

On Fri, Mar 30, 2007 at 12:05:34AM +0200, Pablo Neira Ayuso wrote:
> Sorry for the late reply.
> 
> Phil Dibowitz wrote:
> > --- libnetfilter_conntrack-0.0.50/include/libnetfilter_conntrack/linux_nfnetlink_conntrack.h.orig	2007-03-19 22:53:08.000000000 -0700
> > +++ libnetfilter_conntrack-0.0.50/include/libnetfilter_conntrack/linux_nfnetlink_conntrack.h	2007-03-19 22:53:30.000000000 -0700
> > @@ -2,6 +2,10 @@
> >  #define _IPCONNTRACK_NETLINK_H
> >  #include <libnfnetlink/linux_nfnetlink.h>
> >  
> > +#ifdef __cplusplus
> > +extern "C" {
> > +#endif
> > +
> 
> Do you really need to include the extern "C" in linux_nfnetlink_conntrack.h?

I believe so, yes. The alternative is to put it around the #include of
linux_nfnetlink_conntrack.h inside of libnetfilter_conntrack.h, but that isn't
as clean and prevents anyone from using it directly. Anything in /usr/include
is fair game for using in an #include, and thus should be extern-C-safe.

-- 
Phil Dibowitz                             phil@ipom.com
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Never write it in C if you can do it in 'awk';
 Never do it in 'awk' if 'sed' can handle it;
 Never use 'sed' when 'tr' can do the job;
 Never invoke 'tr' when 'cat' is sufficient;
 Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]