From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Dibowitz <phil@ipom.com>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] libnetfilter_conntrack: add extern C's to public headers
Date: Fri, 30 Mar 2007 00:35:49 +0200 [thread overview]
Message-ID: <460C3F45.4040406@netfilter.org> (raw)
In-Reply-To: <20070329221220.GC15170@ipom.com>
Phil Dibowitz wrote:
> On Fri, Mar 30, 2007 at 12:05:34AM +0200, Pablo Neira Ayuso wrote:
>> Do you really need to include the extern "C" in linux_nfnetlink_conntrack.h?
>
> I believe so, yes. The alternative is to put it around the #include of
> linux_nfnetlink_conntrack.h inside of libnetfilter_conntrack.h, but that isn't
> as clean and prevents anyone from using it directly. Anything in /usr/include
> is fair game for using in an #include, and thus should be extern-C-safe.
Applied. Thanks Phil.
BTW, got no reply on my suggestion about your project name. Thoughts?
--
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris
next prev parent reply other threads:[~2007-03-29 22:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 6:07 [PATCH] libnetfilter_conntrack: add extern C's to public headers Phil Dibowitz
2007-03-29 5:55 ` Phil Dibowitz
2007-03-29 22:05 ` Pablo Neira Ayuso
2007-03-29 22:12 ` Phil Dibowitz
2007-03-29 22:35 ` Pablo Neira Ayuso [this message]
2007-03-29 23:11 ` Phil Dibowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460C3F45.4040406@netfilter.org \
--to=pablo@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=phil@ipom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.