All of lore.kernel.org
 help / color / mirror / Atom feed
From: "M. Warner Losh" <imp@bsdimp.com>
To: qemu-devel@nongnu.org, ths@networkno.de
Subject: Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD
Date: Mon, 02 Apr 2007 08:58:51 -0600 (MDT)	[thread overview]
Message-ID: <20070402.085851.796899796.imp@bsdimp.com> (raw)
In-Reply-To: <20070402124122.GE24846@networkno.de>

In message: <20070402124122.GE24846@networkno.de>
            Thiemo Seufer <ths@networkno.de> writes:
: I made that "#ifdef _BSD" based on the assumption it is ok for all
: BSD variants, including Darwin.

_BSD isn't defined on all variants of BSD.  sys/param.h defines BSD to
be 199506 on all BSD systems (at least all of them derived from 4.4BSD
lite).  sys/param.h also defines BSD4_3 and BSD4_4.  FreeBSD defines
__FreeBSD__ in the compiler, NetBSD defined __NetBSD__, OpenBSD
defines __OpenBSD__.  I'm unsure what darwin/osx define.

so unless I missed a change elsewhere in the build system to define
_BSD, this change needs some more thought.

Warner

  reply	other threads:[~2007-04-02 15:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-02 10:25 [Qemu-devel] Patch: dyngen-exec.h for OpenBSD Juergen Keil
2007-04-02 12:41 ` Thiemo Seufer
2007-04-02 14:58   ` M. Warner Losh [this message]
2007-04-02 16:08     ` Thiemo Seufer
2007-04-02 16:55       ` M. Warner Losh
  -- strict thread matches above, loose matches on Subject: below --
2007-03-21  2:39 Todd T. Fries
2007-04-02  9:54 ` Thiemo Seufer
2007-04-05 22:12   ` Todd T. Fries
2007-04-06 23:21     ` Thiemo Seufer
2007-04-07  0:50     ` Paul Brook
2007-04-07  3:34       ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070402.085851.796899796.imp@bsdimp.com \
    --to=imp@bsdimp.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ths@networkno.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.