Re: [Qemu-devel] Patch: dyngen-exec.h for OpenBSD

[Thiemo Seufer <ths@networkno.de>]

Todd T. Fries wrote:
> This is relative to the 20070319 snapshot.
> 
> 
> --- dyngen-exec.h.orig	Mon Feb  5 17:01:54 2007
> +++ dyngen-exec.h	Sat Mar 10 16:39:39 2007
> @@ -27,11 +27,15 @@
>  #define _FILEDEFED
>  #endif
>  
> +#include "config.h"
> +

Doesn't seem to be necessary in the header.

>  /* NOTE: standard headers should be used with special care at this
>     point because host CPU registers are used as global variables. Some
>     host headers do not allow that. */
>  #include <stddef.h>
> -
> +#ifdef __OpenBSD__
> +#include <sys/types.h>
> +#else
>  typedef unsigned char uint8_t;
>  typedef unsigned short uint16_t;
>  typedef unsigned int uint32_t;
> @@ -61,6 +65,7 @@ typedef signed long int64_t;
>  typedef signed long long int64_t;
>  #endif
>  #endif
> +#endif

Is this specialcase really needed for OpenBSD?

>  /* XXX: This may be wrong for 64-bit ILP32 hosts.  */
>  typedef void * host_reg_t;
> @@ -78,11 +83,15 @@ typedef void * host_reg_t;
>  #define UINT32_MAX		(4294967295U)
>  #define UINT64_MAX		((uint64_t)(18446744073709551615))
>  
> +#ifdef __OpenBSD__
> +typedef struct __sFILE FILE;
> +#else
>  typedef struct FILE FILE;
>  extern int fprintf(FILE *, const char *, ...);
>  extern int printf(const char *, ...);
>  #undef NULL
>  #define NULL 0
> +#endif

Shouldn't this cover only the FILE typedef?


Thiemo