From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] include KERN_* constant in printk() calls in
Date: Mon, 09 Apr 2007 21:41:33 +0000 [thread overview]
Message-ID: <20070409214132.GC26692@parisc-linux.org> (raw)
In-Reply-To: <20070409194151.GG4262@traven>
On Mon, Apr 09, 2007 at 10:53:21PM +0200, Matthias Kaehlcke wrote:
> here comes v0.02 of the patch, i hope it is more useful than the first
> one
You've made the lines go beyond 80 columns.
> if (res) {
> - printk("SLAB: cache with size %d has lost its name\n",
> + printk(KERN_ERR "SLAB: cache with size %d has lost its name\n",
> pc->buffer_size);
> continue;
Try this instead:
+ printk(KERN_ERR "SLAB: cache with size %d has lost its"
+ " name\n", pc->buffer_size);
(ditto the other changes you made).
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2007-04-09 21:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-09 19:41 [KJ] [PATCH] include KERN_* constant in printk() calls in mm/slab.c Matthias Kaehlcke
2007-04-09 20:02 ` [KJ] [PATCH] include KERN_* constant in printk() calls in Dave Jones
2007-04-09 20:08 ` Matthias Kaehlcke
2007-04-09 20:53 ` Matthias Kaehlcke
2007-04-09 21:23 ` Matthew Wilcox
2007-04-09 21:41 ` Matthew Wilcox [this message]
2007-04-10 6:48 ` Matthias Kaehlcke
2007-04-10 21:07 ` Alexey Dobriyan
2007-04-10 21:37 ` Dave Jones
2007-04-10 21:50 ` Robert P. J. Day
2007-04-10 21:58 ` Randy Dunlap
2007-04-11 6:50 ` Matthias Kaehlcke
2007-04-14 5:50 ` [PATCH] include KERN_* constant in printk() calls in arch/i386/mach-default/setup.c Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070409214132.GC26692@parisc-linux.org \
--to=matthew@wil.cx \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.