All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>,
	linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: Build error : 2.6.21-rc6-mm1 on sparc64
Date: Wed, 11 Apr 2007 02:41:20 +0000	[thread overview]
Message-ID: <20070411024120.GA26931@Krystal> (raw)
In-Reply-To: <20070410193429.ffbfa33c.akpm@linux-foundation.org>

* Andrew Morton (akpm@linux-foundation.org) wrote:
> On Wed, 11 Apr 2007 11:15:39 +0900 Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp> wrote:
> 
> > The problem is that to use hard_smp_processor_id in UP kernels just
> > including linux/smp.h does not suffice anymore. Now
> > hard_smp_processor_id is architecture specific code and consequently
> > asm/smp.h should be included explicitly.
> 
> yeah.  The fact that linux/smp.h only exposes asm/smp.h if CONFIG_SMP hits
> us again and again and again.  It would be good to fix that up, I guess by
> including asm/smp.h unconditionally from within linux/smp.h.
> 
> But that's a separate little project.
> 
> > Mathieu, does the (untested) patch below fix this issue?
> 

With this patch, sparc64 builds correctly. Thanks!


> I'll test it.
> 

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>,
	linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: Build error : 2.6.21-rc6-mm1 on sparc64
Date: Tue, 10 Apr 2007 22:41:20 -0400	[thread overview]
Message-ID: <20070411024120.GA26931@Krystal> (raw)
In-Reply-To: <20070410193429.ffbfa33c.akpm@linux-foundation.org>

* Andrew Morton (akpm@linux-foundation.org) wrote:
> On Wed, 11 Apr 2007 11:15:39 +0900 Fernando Luis Vázquez Cao <fernando@oss.ntt.co.jp> wrote:
> 
> > The problem is that to use hard_smp_processor_id in UP kernels just
> > including linux/smp.h does not suffice anymore. Now
> > hard_smp_processor_id is architecture specific code and consequently
> > asm/smp.h should be included explicitly.
> 
> yeah.  The fact that linux/smp.h only exposes asm/smp.h if CONFIG_SMP hits
> us again and again and again.  It would be good to fix that up, I guess by
> including asm/smp.h unconditionally from within linux/smp.h.
> 
> But that's a separate little project.
> 
> > Mathieu, does the (untested) patch below fix this issue?
> 

With this patch, sparc64 builds correctly. Thanks!


> I'll test it.
> 

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

  reply	other threads:[~2007-04-11  2:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-11  0:48 Build error : 2.6.21-rc6-mm1 on sparc64 Mathieu Desnoyers
2007-04-11  0:48 ` Mathieu Desnoyers
2007-04-11  1:18 ` Andrew Morton
2007-04-11  1:18   ` Andrew Morton
2007-04-11  2:15   ` 
2007-04-11  2:15     ` Fernando Luis Vázquez Cao
2007-04-11  2:34     ` Andrew Morton
2007-04-11  2:34       ` Andrew Morton
2007-04-11  2:41       ` Mathieu Desnoyers [this message]
2007-04-11  2:41         ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070411024120.GA26931@Krystal \
    --to=mathieu.desnoyers@polymtl.ca \
    --cc=akpm@linux-foundation.org \
    --cc=fernando@oss.ntt.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.