From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linux-kernel@vger.kernel.org, corentincj@iksaif.net,
sziwan@users.sourceforge.net,
acpi4asus-user@lists.sourceforge.net, len.brown@intel.com,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model
Date: Wed, 11 Apr 2007 13:20:53 -0700 [thread overview]
Message-ID: <20070411132053.899462b4.akpm@linux-foundation.org> (raw)
In-Reply-To: <2189310342910921713@karneval.cz>
On Wed, 11 Apr 2007 15:04:35 +0200 (CEST)
Jiri Slaby <jirislaby@gmail.com> wrote:
> @@ -706,6 +718,8 @@ static int get_lcd_state(void)
> {
> int lcd = 0;
>
> + BUG_ON(!hotk->methods->lcd_status);
mutter. We could just warn-and-bale here.
Hopefully this is just an is-jiri-sane assertion and it should never happen,
no matter how busted the BIOS tables are?
If it _does_ ever trigger, well, we just took out someone's machine
quite unnecessarily.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <corentincj@iksaif.net>,
<sziwan@users.sourceforge.net>,
<acpi4asus-user@lists.sourceforge.net>, <len.brown@intel.com>,
<linux-acpi@vger.kernel.org>
Subject: Re: [PATCH 1/1] ACPI: asus_acpi, support F2JE model
Date: Wed, 11 Apr 2007 13:20:53 -0700 [thread overview]
Message-ID: <20070411132053.899462b4.akpm@linux-foundation.org> (raw)
In-Reply-To: <2189310342910921713@karneval.cz>
On Wed, 11 Apr 2007 15:04:35 +0200 (CEST)
Jiri Slaby <jirislaby@gmail.com> wrote:
> @@ -706,6 +718,8 @@ static int get_lcd_state(void)
> {
> int lcd = 0;
>
> + BUG_ON(!hotk->methods->lcd_status);
mutter. We could just warn-and-bale here.
Hopefully this is just an is-jiri-sane assertion and it should never happen,
no matter how busted the BIOS tables are?
If it _does_ ever trigger, well, we just took out someone's machine
quite unnecessarily.
next prev parent reply other threads:[~2007-04-11 20:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-11 13:04 [PATCH 1/1] ACPI: asus_acpi, support F2JE model Jiri Slaby
2007-04-11 13:04 ` Jiri Slaby
2007-04-11 20:20 ` Andrew Morton [this message]
2007-04-11 20:20 ` Andrew Morton
2007-04-11 20:32 ` Jiri Slaby
2007-04-11 20:37 ` Jiri Slaby
2007-04-11 21:06 ` Andrew Morton
2007-04-11 21:17 ` Jiri Slaby
-- strict thread matches above, loose matches on Subject: below --
2007-04-11 9:33 Jiri Slaby
2007-04-11 9:33 ` Jiri Slaby
2007-04-11 13:05 ` Corentin CHARY
2007-04-11 13:05 ` Corentin CHARY
2007-04-11 13:46 ` Jiri Slaby
2007-04-11 18:18 ` Danny Kukawka
2007-04-11 18:18 ` Danny Kukawka
2007-04-11 18:32 ` Danny Kukawka
2007-04-11 18:32 ` Danny Kukawka
2007-04-11 19:23 ` Jiri Slaby
2007-04-11 19:23 ` Jiri Slaby
2007-04-11 19:43 ` Danny Kukawka
2007-04-11 13:10 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070411132053.899462b4.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentincj@iksaif.net \
--cc=jirislaby@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sziwan@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.