All of lore.kernel.org
 help / color / mirror / Atom feed
* [KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c
  2007-04-11 15:38   ` [KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c Alan Cox
@ 2007-04-11 15:40 ` Milind Arun Choudhary
  -1 siblings, 0 replies; 10+ messages in thread
From: Milind Arun Choudhary @ 2007-04-11 15:28 UTC (permalink / raw)
  To: kernel-janitors; +Cc: linux-ide, linux-kernel, akpm, alan

remove SPIN_LOCK_UNLOCKED, use DEFINE_SPINLOCK instead

Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>

---
 pata_winbond.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)


diff --git a/drivers/ata/pata_winbond.c b/drivers/ata/pata_winbond.c
index 6c11103..cfcd2a5 100644
--- a/drivers/ata/pata_winbond.c
+++ b/drivers/ata/pata_winbond.c
@@ -36,7 +36,7 @@ static int probe_winbond = 1;
 static int probe_winbond;
 #endif
 
-static spinlock_t winbond_lock = SPIN_LOCK_UNLOCKED;
+static DEFINE_SPINLOCK(winbond_lock);
 
 static void winbond_writecfg(unsigned long port, u8 reg, u8 val)
 {

-- 
Milind Arun Choudhary

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [KJ] [PATCH] SPIN_LOCK_UNLOCKED cleanup in
  2007-04-11 15:40 ` [KJ] [PATCH] SPIN_LOCK_UNLOCKED cleanup in Milind Arun Choudhary
@ 2007-04-11 15:38   ` Alan Cox
  -1 siblings, 0 replies; 10+ messages in thread
From: Alan Cox @ 2007-04-11 15:38 UTC (permalink / raw)
  To: Milind Arun Choudhary
  Cc: kernel-janitors, linux-ide, linux-kernel, akpm, alan

On Wed, Apr 11, 2007 at 08:58:46PM +0530, Milind Arun Choudhary wrote:
> remove SPIN_LOCK_UNLOCKED, use DEFINE_SPINLOCK instead
> 
> Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>

Acked-by: Alan Cox <alan@redhat.com>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c
@ 2007-04-11 15:38   ` Alan Cox
  0 siblings, 0 replies; 10+ messages in thread
From: Alan Cox @ 2007-04-11 15:38 UTC (permalink / raw)
  To: Milind Arun Choudhary
  Cc: kernel-janitors, linux-ide, linux-kernel, akpm, alan

On Wed, Apr 11, 2007 at 08:58:46PM +0530, Milind Arun Choudhary wrote:
> remove SPIN_LOCK_UNLOCKED, use DEFINE_SPINLOCK instead
> 
> Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>

Acked-by: Alan Cox <alan@redhat.com>

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [KJ] [PATCH] SPIN_LOCK_UNLOCKED cleanup in
@ 2007-04-11 15:40 ` Milind Arun Choudhary
  0 siblings, 0 replies; 10+ messages in thread
From: Milind Arun Choudhary @ 2007-04-11 15:40 UTC (permalink / raw)
  To: kernel-janitors; +Cc: linux-ide, linux-kernel, akpm, alan

remove SPIN_LOCK_UNLOCKED, use DEFINE_SPINLOCK instead

Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>

---
 pata_winbond.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)


diff --git a/drivers/ata/pata_winbond.c b/drivers/ata/pata_winbond.c
index 6c11103..cfcd2a5 100644
--- a/drivers/ata/pata_winbond.c
+++ b/drivers/ata/pata_winbond.c
@@ -36,7 +36,7 @@ static int probe_winbond = 1;
 static int probe_winbond;
 #endif
 
-static spinlock_t winbond_lock = SPIN_LOCK_UNLOCKED;
+static DEFINE_SPINLOCK(winbond_lock);
 
 static void winbond_writecfg(unsigned long port, u8 reg, u8 val)
 {

-- 
Milind Arun Choudhary
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [KJ] [PATCH] SPIN_LOCK_UNLOCKED cleanup in
  2007-04-11 15:40 ` [KJ] [PATCH] SPIN_LOCK_UNLOCKED cleanup in Milind Arun Choudhary
@ 2007-04-11 15:44   ` Jan Engelhardt
  -1 siblings, 0 replies; 10+ messages in thread
From: Jan Engelhardt @ 2007-04-11 15:44 UTC (permalink / raw)
  To: Milind Arun Choudhary
  Cc: kernel-janitors, linux-ide, linux-kernel, akpm, alan


On Apr 11 2007 20:58, Milind Arun Choudhary wrote:
>
>remove SPIN_LOCK_UNLOCKED, use DEFINE_SPINLOCK instead

Don't we have some more places where spinlocks could be janitorified?
Otherwise, ok!


Jan
-- 
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c
@ 2007-04-11 15:44   ` Jan Engelhardt
  0 siblings, 0 replies; 10+ messages in thread
From: Jan Engelhardt @ 2007-04-11 15:44 UTC (permalink / raw)
  To: Milind Arun Choudhary
  Cc: kernel-janitors, linux-ide, linux-kernel, akpm, alan


On Apr 11 2007 20:58, Milind Arun Choudhary wrote:
>
>remove SPIN_LOCK_UNLOCKED, use DEFINE_SPINLOCK instead

Don't we have some more places where spinlocks could be janitorified?
Otherwise, ok!


Jan
-- 

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in
@ 2007-04-11 17:55 ` Milind Arun Choudhary
  0 siblings, 0 replies; 10+ messages in thread
From: Milind Arun Choudhary @ 2007-04-11 17:54 UTC (permalink / raw)
  To: kernel-janitors; +Cc: linux1394-devel, akpm, linux-kernel, bcollins, stefanr

SPIN_LOCK_UNLOCKED cleanup,use DEFINE_SPINLOCK instead 

Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
---

 ieee1394_transactions.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ieee1394/ieee1394_transactions.c b/drivers/ieee1394/ieee1394_transactions.c
index 0833fc9..8563077 100644
--- a/drivers/ieee1394/ieee1394_transactions.c
+++ b/drivers/ieee1394/ieee1394_transactions.c
@@ -32,7 +32,7 @@
 #ifndef HPSB_DEBUG_TLABELS
 static
 #endif
-spinlock_t hpsb_tlabel_lock = SPIN_LOCK_UNLOCKED;
+DEFINE_SPINLOCK(hpsb_tlabel_lock);
 
 static DECLARE_WAIT_QUEUE_HEAD(tlabel_wq);
 
-- 
Milind Arun Choudhary

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [KJ] [PATCH]SPIN_LOCK_UNLOCKED cleanup in
@ 2007-04-11 17:55 ` Milind Arun Choudhary
  0 siblings, 0 replies; 10+ messages in thread
From: Milind Arun Choudhary @ 2007-04-11 17:55 UTC (permalink / raw)
  To: kernel-janitors; +Cc: linux1394-devel, akpm, linux-kernel, bcollins, stefanr

SPIN_LOCK_UNLOCKED cleanup,use DEFINE_SPINLOCK instead 

Signed-off-by: Milind Arun Choudhary <milindchoudhary@gmail.com>
---

 ieee1394_transactions.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ieee1394/ieee1394_transactions.c b/drivers/ieee1394/ieee1394_transactions.c
index 0833fc9..8563077 100644
--- a/drivers/ieee1394/ieee1394_transactions.c
+++ b/drivers/ieee1394/ieee1394_transactions.c
@@ -32,7 +32,7 @@
 #ifndef HPSB_DEBUG_TLABELS
 static
 #endif
-spinlock_t hpsb_tlabel_lock = SPIN_LOCK_UNLOCKED;
+DEFINE_SPINLOCK(hpsb_tlabel_lock);
 
 static DECLARE_WAIT_QUEUE_HEAD(tlabel_wq);
 
-- 
Milind Arun Choudhary
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [KJ] [PATCH]SPIN_LOCK_UNLOCKED cleanup in
  2007-04-11 17:55 ` [KJ] [PATCH]SPIN_LOCK_UNLOCKED " Milind Arun Choudhary
@ 2007-04-11 20:45   ` Stefan Richter
  -1 siblings, 0 replies; 10+ messages in thread
From: Stefan Richter @ 2007-04-11 20:45 UTC (permalink / raw)
  To: Milind Arun Choudhary
  Cc: kernel-janitors, linux1394-devel, akpm, linux-kernel, bcollins

Milind Arun Choudhary wrote:
> SPIN_LOCK_UNLOCKED cleanup,use DEFINE_SPINLOCK instead 

Committed to linux1394-2.6.git. Thanks,
-- 
Stefan Richter
-===-=-== -=-- -=-=
http://arcgraph.de/sr/
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in
@ 2007-04-11 20:45   ` Stefan Richter
  0 siblings, 0 replies; 10+ messages in thread
From: Stefan Richter @ 2007-04-11 20:45 UTC (permalink / raw)
  To: Milind Arun Choudhary
  Cc: kernel-janitors, linux1394-devel, akpm, linux-kernel, bcollins

Milind Arun Choudhary wrote:
> SPIN_LOCK_UNLOCKED cleanup,use DEFINE_SPINLOCK instead 

Committed to linux1394-2.6.git. Thanks,
-- 
Stefan Richter
-=====-=-=== -=-- -=-==
http://arcgraph.de/sr/

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2007-04-11 20:46 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-11 15:28 [KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c Milind Arun Choudhary
2007-04-11 15:40 ` [KJ] [PATCH] SPIN_LOCK_UNLOCKED cleanup in Milind Arun Choudhary
2007-04-11 15:38 ` Alan Cox
2007-04-11 15:38   ` [KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c Alan Cox
2007-04-11 15:44 ` [KJ] [PATCH] SPIN_LOCK_UNLOCKED cleanup in Jan Engelhardt
2007-04-11 15:44   ` [KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c Jan Engelhardt
  -- strict thread matches above, loose matches on Subject: below --
2007-04-11 17:54 [KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in Milind Arun Choudhary
2007-04-11 17:55 ` [KJ] [PATCH]SPIN_LOCK_UNLOCKED " Milind Arun Choudhary
2007-04-11 20:45 ` Stefan Richter
2007-04-11 20:45   ` [KJ][PATCH]SPIN_LOCK_UNLOCKED " Stefan Richter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.