All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 06/29] Use skb timestamp for TX side
Date: Thu, 12 Apr 2007 21:21:03 +0000	[thread overview]
Message-ID: <20070412.142103.10320549.davem@davemloft.net> (raw)
In-Reply-To: <20070412211446.GG21292@ghostprotocols.net>

From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Date: Thu, 12 Apr 2007 18:14:46 -0300

>  This patch uses skb timestamps (and provides the necessary enable/disable
>  mechanism) instead of layer-4 timestamping. This affords a more accurate
>  RTT estimation.
> 
> Background:
> 
>  The sender currently computes the timestamp of received (Ack) packets when
>  the packet is delivered to layer 4. The skb timestamp is taken earlier, and
>  the differences are notable: dDuring test runs under different load conditions,
>  the layer-4 timestamp was observed to be on average up to 100 microseconds,
>  in the extreme up to a millisecond, later than the skb timestamp.
>  This has a negative impact on the RTT estimation (reduced accuracy).
> 
> Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
> Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>

This patch screws the entire system over with the overhead of
timestamping every packet processed as soon as there are DCCP sockets
using ccid3.

I'll pull this in for now, but you must find a better way before
I merge this to Linus for 2.6.22

  reply	other threads:[~2007-04-12 21:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-12 21:14 [PATCH 06/29] Use skb timestamp for TX side Arnaldo Carvalho de Melo
2007-04-12 21:21 ` David Miller [this message]
2007-04-12 21:52 ` Ian McDonald

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070412.142103.10320549.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.