From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: dccp@vger.kernel.org
Subject: [PATCH 06/29] Use skb timestamp for TX side
Date: Thu, 12 Apr 2007 21:14:46 +0000 [thread overview]
Message-ID: <20070412211446.GG21292@ghostprotocols.net> (raw)
This patch uses skb timestamps (and provides the necessary enable/disable
mechanism) instead of layer-4 timestamping. This affords a more accurate
RTT estimation.
Background:
The sender currently computes the timestamp of received (Ack) packets when
the packet is delivered to layer 4. The skb timestamp is taken earlier, and
the differences are notable: dDuring test runs under different load conditions,
the layer-4 timestamp was observed to be on average up to 100 microseconds,
in the extreme up to a millisecond, later than the skb timestamp.
This has a negative impact on the RTT estimation (reduced accuracy).
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
---
net/dccp/ccids/ccid3.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/dccp/ccids/ccid3.c b/net/dccp/ccids/ccid3.c
index b756e95..a20b636 100644
--- a/net/dccp/ccids/ccid3.c
+++ b/net/dccp/ccids/ccid3.c
@@ -469,7 +469,7 @@ static void ccid3_hc_tx_packet_recv(struct sock *sk, struct sk_buff *skb)
else /* can not exceed 100% */
hctx->ccid3hctx_p = 1000000 / pinv;
- do_gettimeofday(&now);
+ skb_get_timestamp(skb, &now);
/*
* Calculate new round trip sample as per [RFC 3448, 4.3] by
@@ -645,6 +645,7 @@ static int ccid3_hc_tx_init(struct ccid *ccid, struct sock *sk)
ccid3_hc_tx_no_feedback_timer;
hctx->ccid3hctx_no_feedback_timer.data = (unsigned long)sk;
init_timer(&hctx->ccid3hctx_no_feedback_timer);
+ net_enable_timestamp();
return 0;
}
@@ -657,6 +658,7 @@ static void ccid3_hc_tx_exit(struct sock *sk)
ccid3_hc_tx_set_state(sk, TFRC_SSTATE_TERM);
sk_stop_timer(sk, &hctx->ccid3hctx_no_feedback_timer);
+ net_disable_timestamp();
/* Empty packet history */
dccp_tx_hist_purge(ccid3_tx_hist, &hctx->ccid3hctx_hist);
--
1.5.0.6
next reply other threads:[~2007-04-12 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 21:14 Arnaldo Carvalho de Melo [this message]
2007-04-12 21:21 ` [PATCH 06/29] Use skb timestamp for TX side David Miller
2007-04-12 21:52 ` Ian McDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070412211446.GG21292@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.