From: Matthew Wilcox <matthew@wil.cx>
To: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
David Somayajulu <david.somayajulu@qlogic.com>,
scsi <linux-scsi@vger.kernel.org>,
PCI <linux-pci@atrey.karlin.mff.cuni.cz>,
linux-driver@qlogic.com, gregkh <greg@kroah.com>,
linuxppc-dev@ozlabs.org
Subject: Re: qla_wxyz pci_set_mwi question
Date: Thu, 12 Apr 2007 14:04:38 -0600 [thread overview]
Message-ID: <20070412200438.GM26692@parisc-linux.org> (raw)
In-Reply-To: <20070412193713.GB14510@andrew-vasquezs-computer.local>
On Thu, Apr 12, 2007 at 12:37:13PM -0700, Andrew Vasquez wrote:
> On Thu, 12 Apr 2007, Matthew Wilcox wrote:
> > Why should it fail? If there's a platform which can't support a
> > cacheline size that the qla2xyz card can handle, it should be able to
> > happily fall back to doing plain writes instead of MWIs. IMO, it should
> > just call pci_set_mwi() and ignore the result.
>
> I believe there were some erratas on some ISP2xxx chips where MWI
> needed to be set for proper operation. I'll go back, verify and
> update the patch accordingly.
Hmm. The thing is that pci_set_mwi() returns success on machines where
MWI is disabled (currently only PPC64). Perhaps it needs to fail
instead.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <matthew@wil.cx>
To: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
scsi <linux-scsi@vger.kernel.org>, gregkh <greg@kroah.com>,
David Somayajulu <david.somayajulu@qlogic.com>,
linuxppc-dev@ozlabs.org, linux-driver@qlogic.com,
PCI <linux-pci@atrey.karlin.mff.cuni.cz>
Subject: Re: qla_wxyz pci_set_mwi question
Date: Thu, 12 Apr 2007 14:04:38 -0600 [thread overview]
Message-ID: <20070412200438.GM26692@parisc-linux.org> (raw)
In-Reply-To: <20070412193713.GB14510@andrew-vasquezs-computer.local>
On Thu, Apr 12, 2007 at 12:37:13PM -0700, Andrew Vasquez wrote:
> On Thu, 12 Apr 2007, Matthew Wilcox wrote:
> > Why should it fail? If there's a platform which can't support a
> > cacheline size that the qla2xyz card can handle, it should be able to
> > happily fall back to doing plain writes instead of MWIs. IMO, it should
> > just call pci_set_mwi() and ignore the result.
>
> I believe there were some erratas on some ISP2xxx chips where MWI
> needed to be set for proper operation. I'll go back, verify and
> update the patch accordingly.
Hmm. The thing is that pci_set_mwi() returns success on machines where
MWI is disabled (currently only PPC64). Perhaps it needs to fail
instead.
next prev parent reply other threads:[~2007-04-12 20:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 5:15 qla_wxyz pci_set_mwi question Randy Dunlap
2007-04-12 17:20 ` Andrew Vasquez
2007-04-12 18:53 ` Matthew Wilcox
2007-04-12 19:37 ` Andrew Vasquez
2007-04-12 20:04 ` Matthew Wilcox [this message]
2007-04-12 20:04 ` Matthew Wilcox
2007-04-13 2:34 ` Benjamin Herrenschmidt
2007-04-13 2:34 ` Benjamin Herrenschmidt
2007-04-13 2:40 ` Randy Dunlap
2007-04-13 2:40 ` Randy Dunlap
2007-04-13 2:43 ` Benjamin Herrenschmidt
2007-04-13 2:43 ` Benjamin Herrenschmidt
2007-05-03 17:44 ` Andrew Vasquez
2007-05-03 17:44 ` Andrew Vasquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070412200438.GM26692@parisc-linux.org \
--to=matthew@wil.cx \
--cc=andrew.vasquez@qlogic.com \
--cc=david.somayajulu@qlogic.com \
--cc=greg@kroah.com \
--cc=linux-driver@qlogic.com \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.