All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: dccp@vger.kernel.org
Subject: [PATCH 07/29] Use skb timestamp for receiver side
Date: Thu, 12 Apr 2007 21:14:54 +0000	[thread overview]
Message-ID: <20070412211454.GH21292@ghostprotocols.net> (raw)

 This patch replaces calls to do_gettimeofday at the receiver CCID 3
 with skb timestamps. The skb timestamps are computed earlier in the
 receive path, experimental measurements have shown that up to several
 hundred microseconds can lie between the skb receive timestamp and the
 timestamp taken when CCID 3 receives the packet. This difference has
 a negative impact on RTT estimation (reduced accuracy).

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
---
 net/dccp/ccids/lib/packet_history.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/dccp/ccids/lib/packet_history.h b/net/dccp/ccids/lib/packet_history.h
index b40b9f9..330b58f 100644
--- a/net/dccp/ccids/lib/packet_history.h
+++ b/net/dccp/ccids/lib/packet_history.h
@@ -151,7 +151,7 @@ static inline struct dccp_rx_hist_entry *
 		entry->dccphrx_ccval = dh->dccph_ccval;
 		entry->dccphrx_type  = dh->dccph_type;
 		entry->dccphrx_ndp   = ndp;
-		do_gettimeofday(&entry->dccphrx_tstamp);
+		skb_get_timestamp(skb, &entry->dccphrx_tstamp);
 	}
 
 	return entry;
-- 
1.5.0.6


             reply	other threads:[~2007-04-12 21:14 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-12 21:14 Arnaldo Carvalho de Melo [this message]
2007-04-12 21:22 ` [PATCH 07/29] Use skb timestamp for receiver side David Miller
2007-04-12 21:31 ` Arnaldo Carvalho de Melo
2007-04-12 21:50 ` Ian McDonald
2007-04-12 21:57 ` David Miller
2007-04-12 23:27 ` Ian McDonald
2007-04-13  8:59 ` Gerrit Renker
2007-04-13  9:01 ` Gerrit Renker
2007-04-13  9:27 ` Gerrit Renker
2007-04-13  9:37 ` David Miller
2007-04-13  9:48 ` Ian McDonald
2007-04-13  9:51 ` Gerrit Renker
2007-04-13  9:53 ` Gerrit Renker
2007-04-13 10:20 ` Gerrit Renker
2007-04-13 11:56 ` Arnaldo Carvalho de Melo
2007-04-13 12:11 ` Gerrit Renker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070412211454.GH21292@ghostprotocols.net \
    --to=acme@ghostprotocols.net \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.