From: Milind Arun Choudhary <milindchoudhary@gmail.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: kernel-janitors@lists.osdl.org, linux-ia64@vger.kernel.org,
discuss@x86-64.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, ak@suse.de
Subject: Re: [KJ] [PATCH 02/03]ROUND_UP|DOWN macro cleanup in arch/ia64,
Date: Fri, 13 Apr 2007 04:43:40 +0000 [thread overview]
Message-ID: <20070413043140.GA9431@arun.site> (raw)
In-Reply-To: <20070412211334.GA5892@intel.com>
On 14:13 Thu 12 Apr , Luck, Tony wrote:
> On Fri, Apr 13, 2007 at 02:01:40AM +0530, Milind Arun Choudhary wrote:
> > - size = ROUNDUP(size, iovp_size);
> > + size = ALIGN(size, iovp_size);
>
> Why is "ALIGN" better than "ROUNDUP"? I can't see any point
> to this change.
Its a janitorial work. I'm trying to celanup
all the corners where ROUNDUP/DOWN & likes are defined.
Kernel.h currently has macros like ALIGN roundup DIV_ROUND_UP.
in this patch series I've added ALIGN_DOWN & round_down
[waiting for comments on the same.]
So as ALIGN macro does the same work as ROUNDUP,
is at a common place
& is accessible to everyone
it should be used instead...i think
--
Milind Arun Choudhary
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors
WARNING: multiple messages have this Message-ID (diff)
From: Milind Arun Choudhary <milindchoudhary@gmail.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: kernel-janitors@lists.osdl.org, linux-ia64@vger.kernel.org,
discuss@x86-64.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, ak@suse.de
Subject: Re: [KJ][PATCH 02/03]ROUND_UP|DOWN macro cleanup in arch/ia64,x86_64
Date: Fri, 13 Apr 2007 04:43:40 +0000 [thread overview]
Message-ID: <20070413043140.GA9431@arun.site> (raw)
In-Reply-To: <20070412211334.GA5892@intel.com>
On 14:13 Thu 12 Apr , Luck, Tony wrote:
> On Fri, Apr 13, 2007 at 02:01:40AM +0530, Milind Arun Choudhary wrote:
> > - size = ROUNDUP(size, iovp_size);
> > + size = ALIGN(size, iovp_size);
>
> Why is "ALIGN" better than "ROUNDUP"? I can't see any point
> to this change.
Its a janitorial work. I'm trying to celanup
all the corners where ROUNDUP/DOWN & likes are defined.
Kernel.h currently has macros like ALIGN roundup DIV_ROUND_UP.
in this patch series I've added ALIGN_DOWN & round_down
[waiting for comments on the same.]
So as ALIGN macro does the same work as ROUNDUP,
is at a common place
& is accessible to everyone
it should be used instead...i think
--
Milind Arun Choudhary
WARNING: multiple messages have this Message-ID (diff)
From: Milind Arun Choudhary <milindchoudhary@gmail.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: kernel-janitors@lists.osdl.org, linux-ia64@vger.kernel.org,
discuss@x86-64.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, ak@suse.de
Subject: Re: [KJ][PATCH 02/03]ROUND_UP|DOWN macro cleanup in arch/ia64,x86_64
Date: Fri, 13 Apr 2007 10:01:40 +0530 [thread overview]
Message-ID: <20070413043140.GA9431@arun.site> (raw)
In-Reply-To: <20070412211334.GA5892@intel.com>
On 14:13 Thu 12 Apr , Luck, Tony wrote:
> On Fri, Apr 13, 2007 at 02:01:40AM +0530, Milind Arun Choudhary wrote:
> > - size = ROUNDUP(size, iovp_size);
> > + size = ALIGN(size, iovp_size);
>
> Why is "ALIGN" better than "ROUNDUP"? I can't see any point
> to this change.
Its a janitorial work. I'm trying to celanup
all the corners where ROUNDUP/DOWN & likes are defined.
Kernel.h currently has macros like ALIGN roundup DIV_ROUND_UP.
in this patch series I've added ALIGN_DOWN & round_down
[waiting for comments on the same.]
So as ALIGN macro does the same work as ROUNDUP,
is at a common place
& is accessible to everyone
it should be used instead...i think
--
Milind Arun Choudhary
next prev parent reply other threads:[~2007-04-13 4:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-12 20:31 [KJ][PATCH 02/03]ROUND_UP|DOWN macro cleanup in arch/ia64,x86_64 Milind Arun Choudhary
2007-04-12 20:43 ` Milind Arun Choudhary
2007-04-12 20:43 ` [KJ] [PATCH " Milind Arun Choudhary
2007-04-12 21:13 ` [KJ] [PATCH 02/03]ROUND_UP|DOWN macro cleanup in arch/ia64, Luck, Tony
2007-04-12 21:13 ` [KJ][PATCH 02/03]ROUND_UP|DOWN macro cleanup in arch/ia64,x86_64 Luck, Tony
2007-04-12 21:13 ` Luck, Tony
2007-04-13 4:31 ` Milind Arun Choudhary [this message]
2007-04-13 4:43 ` Milind Arun Choudhary
2007-04-13 4:43 ` [KJ] [PATCH 02/03]ROUND_UP|DOWN macro cleanup in arch/ia64, Milind Arun Choudhary
2007-04-13 16:45 ` Luck, Tony
2007-04-13 16:45 ` [KJ][PATCH 02/03]ROUND_UP|DOWN macro cleanup in arch/ia64,x86_64 Luck, Tony
2007-04-13 16:45 ` Luck, Tony
2007-05-30 21:57 ` Oleg Verych
2007-05-30 21:57 ` Oleg Verych
2007-05-30 21:57 ` Oleg Verych
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070413043140.GA9431@arun.site \
--to=milindchoudhary@gmail.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=discuss@x86-64.org \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.