All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: andrew.vasquez@qlogic.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	James.Bottomley@SteelEye.com, ema@debian.org
Subject: Re: Major qla2xxx regression on sparc64
Date: Mon, 16 Apr 2007 15:08:46 -0700 (PDT)	[thread overview]
Message-ID: <20070416.150846.45744461.davem@davemloft.net> (raw)
In-Reply-To: <20070416211049.GC13590@andrew-vasquezs-computer.local>

From: Andrew Vasquez <andrew.vasquez@qlogic.com>
Date: Mon, 16 Apr 2007 14:10:49 -0700

> Ok, how about the following patch based on the one you posted which
> adds the codes to retrieve the WWPN/WWNN from firmware on SPARC, and
> also adds the module-parameter override I mentioned above.
> 
> Perhaps the module-parameter should be set to non-zero in the case of
> SPARC, to take care of your system configurations?

I think it should default to non-zero always, in fact the option
is completely pointless.

The guy who hits this had a system which worked previously, and you're
explicitly breaking it.  That's wrong.

How can you not see that this quality of implementation decision
you're making stinks?

  reply	other threads:[~2007-04-16 22:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-16  8:02 Major qla2xxx regression on sparc64 David Miller
2007-04-16 16:37 ` Andrew Vasquez
2007-04-16 19:37   ` David Miller
2007-04-16 19:59     ` David Miller
2007-04-16 20:08     ` Andrew Vasquez
2007-04-16 21:10       ` Andrew Vasquez
2007-04-16 22:08         ` David Miller [this message]
2007-04-16 22:25           ` Andrew Vasquez
2007-04-16 22:29             ` David Miller
2007-04-16 23:28               ` Andrew Vasquez
2007-04-16 23:41                 ` David Miller
2007-04-16 23:47                   ` Andrew Vasquez
2007-04-17  0:05                     ` David Miller
2007-04-17  2:41                       ` Andrew Vasquez
2007-04-17  5:02                         ` David Miller
2007-04-17 18:28                           ` Seokmann Ju
2007-04-17 18:28                             ` Seokmann Ju
2007-04-17 18:56                             ` David Miller
2007-04-18 17:16                             ` Christoph Hellwig
2007-04-18 20:12                               ` David Miller
2007-04-18 17:13       ` Christoph Hellwig
2007-04-18 17:28         ` Andrew Vasquez
2007-04-18 20:13           ` David Miller
2007-04-19 17:15             ` Andrew Vasquez
2007-04-18 20:10         ` David Miller
2007-04-22 14:31           ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070416.150846.45744461.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=James.Bottomley@SteelEye.com \
    --cc=andrew.vasquez@qlogic.com \
    --cc=ema@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.