All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Contribute a fairly paranoid update hook
Date: Fri, 20 Apr 2007 10:59:23 -0400	[thread overview]
Message-ID: <20070420145923.GB17480@spearce.org> (raw)
In-Reply-To: <7vmz131fzz.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano <junkio@cox.net> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
> 
> > +$ENV{PATH}     = '/opt/git/bin';
> 
> This caught my attention ;-).

What, is replacing PATH in the hook really all that paranoid?
Its a perfectly reasonable thing to do.  ;-)

Someday I'll post the patch to receive-pack that I use to run
it setuid.  That thing is also fairly paranoid.  I won't submit
it for application to git.git though, as I don't think it really
belongs in the main receive-pack code.  So it might be a patch file
for contrib, or just an article in the mailing list archives that
people can link to.

I also recently hacked some semi-useful features into gitweb.cgi.
I need to finish those for our local use, and then see if I can
extract them enough to make them publicly available.  gitweb.cgi is
probably going to become a cornerstone of our main development and
testing workflow, especially for managers and testers who don't want
(or really need) full repositories on their deskstops.

-- 
Shawn.

  reply	other threads:[~2007-04-20 14:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-20  6:08 [PATCH] Contribute a fairly paranoid update hook Shawn O. Pearce
2007-04-20 10:45 ` Junio C Hamano
2007-04-20 14:59   ` Shawn O. Pearce [this message]
2007-04-20 17:27     ` Junio C Hamano
2007-04-21  0:01     ` Jakub Narebski
2007-04-21  3:39       ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070420145923.GB17480@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.