From: Junio C Hamano <junkio@cox.net>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Contribute a fairly paranoid update hook
Date: Fri, 20 Apr 2007 10:27:18 -0700 [thread overview]
Message-ID: <7v647ryn0p.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20070420145923.GB17480@spearce.org> (Shawn O. Pearce's message of "Fri, 20 Apr 2007 10:59:23 -0400")
"Shawn O. Pearce" <spearce@spearce.org> writes:
> Junio C Hamano <junkio@cox.net> wrote:
>> "Shawn O. Pearce" <spearce@spearce.org> writes:
>>
>> > +$ENV{PATH} = '/opt/git/bin';
>>
>> This caught my attention ;-).
>
> What, is replacing PATH in the hook really all that paranoid?
> Its a perfectly reasonable thing to do. ;-)
I 100% agree it is the right thing to to make sure PATH is a
known good value. What caught my attention is /opt/git/bin
is the *ONLY* place you need to look at, not even /usr/bin!
next prev parent reply other threads:[~2007-04-20 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-20 6:08 [PATCH] Contribute a fairly paranoid update hook Shawn O. Pearce
2007-04-20 10:45 ` Junio C Hamano
2007-04-20 14:59 ` Shawn O. Pearce
2007-04-20 17:27 ` Junio C Hamano [this message]
2007-04-21 0:01 ` Jakub Narebski
2007-04-21 3:39 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7v647ryn0p.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.