* Re: [Bugme-new] [Bug 8330] New: lmc: copy_to/from_user cals while spinlock is held
[not found] <200704152128.l3FLSgOB026277@fire-2.osdl.org>
@ 2007-04-20 22:56 ` Andrew Morton
0 siblings, 0 replies; only message in thread
From: Andrew Morton @ 2007-04-20 22:56 UTC (permalink / raw)
To: netdev; +Cc: bugme-daemon@kernel-bugs.osdl.org, matthias.kaehlcke, khc
On Sun, 15 Apr 2007 14:28:42 -0700
bugme-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=8330
>
> Summary: lmc: copy_to/from_user cals while spinlock is held
> Kernel Version: 2.6.20
> Status: NEW
> Severity: normal
> Owner: jgarzik@pobox.com
> Submitter: matthias.kaehlcke@gmail.com
>
>
> Problem Description:
>
> the lmc_ioctl() function in drivers/net/wan/lmc/lmc_main.c calls
> copy_from/to_user() while the spinlock sc->lmc_lock is held. AFAIK this should
> not be done as copy_from/to_user() might sleep
>
urgh. That function is a study in "what not to do while holding a spinlock".
Including "return without having unlocked it".
It is irreparable.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2007-04-20 22:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200704152128.l3FLSgOB026277@fire-2.osdl.org>
2007-04-20 22:56 ` [Bugme-new] [Bug 8330] New: lmc: copy_to/from_user cals while spinlock is held Andrew Morton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.