[patch] ipmi: check, if default ports are accessible on PPC

[patch] ipmi: check, if default ports are accessible on PPC

[Christian Krafft]

[-- Attachment #1: Type: text/plain, Size: 1270 bytes --]

Subject: ipmi: check, if default ports are accessible on PPC

From: Christian Krafft <krafft@de.ibm.com>

ipmi_si_intf tries to access default ports, if no device could
be found elsewhere. On PPC we have a function to check,
if these legacy IO ports are accessible. This patch adds
a check for these ports on PPC.
This patch fixes a breakage of IPMI module
on PPC machines without a BMC.

Signed-off-by: Christian Krafft <krafft@de.ibm.com>

Index: linux/drivers/char/ipmi/ipmi_si_intf.c
===================================================================
--- linux.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux/drivers/char/ipmi/ipmi_si_intf.c
@@ -2580,6 +2580,11 @@ static __devinit void default_find_bmc(v
 		if (!info)
 			return;
 
+#ifdef CONFIG_PPC_MERGE
+		if (check_legacy_ioport(ipmi_defaults[i].port))
+			continue;
+#endif
+
 		info->addr_source = NULL;
 
 		info->si_type = ipmi_defaults[i].type;
 

-- 
Mit freundlichen Gruessen,
kind regards,

Christian Krafft
IBM Systems & Technology Group,
Linux Kernel Development
IT Specialist


Vorsitzender des Aufsichtsrats:	Johann Weihen
Geschaeftsfuehrung:		Herbert Kircher
Sitz der Gesellschaft:		Boeblingen
Registriergericht:		Amtsgericht Stuttgart, HRB 243294


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [patch] ipmi: check, if default ports are accessible on PPC

[Michael Ellerman]

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

On Mon, 2007-02-26 at 16:09 +0100, Christian Krafft wrote:
> Subject: ipmi: check, if default ports are accessible on PPC
> 
> From: Christian Krafft <krafft@de.ibm.com>
> 
> ipmi_si_intf tries to access default ports, if no device could
> be found elsewhere. On PPC we have a function to check,
> if these legacy IO ports are accessible. This patch adds
> a check for these ports on PPC.
> This patch fixes a breakage of IPMI module
> on PPC machines without a BMC.
> 
> Signed-off-by: Christian Krafft <krafft@de.ibm.com>

Yep that fixes the problem on my machine.

Acked-by: Michael Ellerman <michael@ellerman.id.au>

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [patch] ipmi: check, if default ports are accessible on PPC

[Olaf Hering]

On Mon, Feb 26, Christian Krafft wrote:

> ipmi_si_intf tries to access default ports, if no device could
> be found elsewhere. On PPC we have a function to check,
> if these legacy IO ports are accessible. This patch adds
> a check for these ports on PPC.
> This patch fixes a breakage of IPMI module
> on PPC machines without a BMC.

This patch is a no-op even for IPMI capable systems.
None of the platform check_legacy_ioport() functions check for port
number 0xca2, 0xca9 or 0xe4.

What exactly did you test? Appearently not Linus tree.

Re: [patch] ipmi: check, if default ports are accessible on PPC

[Olaf Hering]

On Fri, Apr 20, Olaf Hering wrote:

> On Mon, Feb 26, Christian Krafft wrote:
> 
> > ipmi_si_intf tries to access default ports, if no device could
> > be found elsewhere. On PPC we have a function to check,
> > if these legacy IO ports are accessible. This patch adds
> > a check for these ports on PPC.
> > This patch fixes a breakage of IPMI module
> > on PPC machines without a BMC.
> 
> This patch is a no-op even for IPMI capable systems.

I missed the 'return 0;' in pSeries_check_legacy_ioport().

[PATCH] ipmi: check, if default ports are accessible on PPC

[Corey Minyard]

From: Christian Krafft <krafft@de.ibm.com>

ipmi_si_intf tries to access default ports, if no device could
be found elsewhere. On PPC we have a function to check,
if these legacy IO ports are accessible. This patch adds
a check for these ports on PPC.
This patch fixes a breakage of IPMI module
on PPC machines without a BMC.

Signed-off-by: Christian Krafft <krafft@de.ibm.com>
Acked-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Corey Minyard <minyard@acm.org>

Index: linux/drivers/char/ipmi/ipmi_si_intf.c
===================================================================
--- linux.orig/drivers/char/ipmi/ipmi_si_intf.c
+++ linux/drivers/char/ipmi/ipmi_si_intf.c
@@ -2580,6 +2580,11 @@ static __devinit void default_find_bmc(v
 		if (!info)
 			return;
 
+#ifdef CONFIG_PPC_MERGE
+		if (check_legacy_ioport(ipmi_defaults[i].port))
+			continue;
+#endif
+
 		info->addr_source = NULL;
 
 		info->si_type = ipmi_defaults[i].type;