[PATCH 1/8] Kconfig: refine depends statements.

[PATCH 1/8] Kconfig: refine depends statements.

[Martin Schwidefsky]

From: Martin Schwidefsky <schwidefsky@de.ibm.com>

Refine some depends statements to limit their visibility to the
environments that are actually supported.

Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---

 drivers/auxdisplay/Kconfig     |    1 +
 drivers/char/Kconfig           |    1 +
 drivers/ieee1394/Kconfig       |    1 +
 drivers/kvm/Kconfig            |    1 +
 drivers/message/fusion/Kconfig |    1 +
 drivers/message/i2o/Kconfig    |    1 +
 6 files changed, 6 insertions(+)

diff -urpN linux-2.6/drivers/auxdisplay/Kconfig linux-2.6-patched/drivers/auxdisplay/Kconfig
--- linux-2.6/drivers/auxdisplay/Kconfig	2007-04-19 15:23:55.000000000 +0200
+++ linux-2.6-patched/drivers/auxdisplay/Kconfig	2007-04-19 15:49:17.000000000 +0200
@@ -6,6 +6,7 @@
 #
 
 menu "Auxiliary Display support"
+	depends on PARPORT_PC
 
 config KS0108
 	tristate "KS0108 LCD Controller"
diff -urpN linux-2.6/drivers/char/Kconfig linux-2.6-patched/drivers/char/Kconfig
--- linux-2.6/drivers/char/Kconfig	2007-04-19 15:24:32.000000000 +0200
+++ linux-2.6-patched/drivers/char/Kconfig	2007-04-19 15:49:17.000000000 +0200
@@ -867,6 +867,7 @@ config COBALT_LCD
 
 config DTLK
 	tristate "Double Talk PC internal speech card support"
+	depends on ISA
 	help
 	  This driver is for the DoubleTalk PC, a speech synthesizer
 	  manufactured by RC Systems (<http://www.rcsys.com/>).  It is also
diff -urpN linux-2.6/drivers/ieee1394/Kconfig linux-2.6-patched/drivers/ieee1394/Kconfig
--- linux-2.6/drivers/ieee1394/Kconfig	2007-04-19 15:24:33.000000000 +0200
+++ linux-2.6-patched/drivers/ieee1394/Kconfig	2007-04-19 15:49:17.000000000 +0200
@@ -1,6 +1,7 @@
 # -*- shell-script -*-
 
 menu "IEEE 1394 (FireWire) support"
+	depends on PCI || BROKEN
 
 source "drivers/firewire/Kconfig"
 
diff -urpN linux-2.6/drivers/kvm/Kconfig linux-2.6-patched/drivers/kvm/Kconfig
--- linux-2.6/drivers/kvm/Kconfig	2007-02-04 19:44:54.000000000 +0100
+++ linux-2.6-patched/drivers/kvm/Kconfig	2007-04-19 15:49:17.000000000 +0200
@@ -2,6 +2,7 @@
 # KVM configuration
 #
 menu "Virtualization"
+	depends on X86
 
 config KVM
 	tristate "Kernel-based Virtual Machine (KVM) support"
diff -urpN linux-2.6/drivers/message/fusion/Kconfig linux-2.6-patched/drivers/message/fusion/Kconfig
--- linux-2.6/drivers/message/fusion/Kconfig	2007-04-19 15:24:00.000000000 +0200
+++ linux-2.6-patched/drivers/message/fusion/Kconfig	2007-04-19 15:49:17.000000000 +0200
@@ -1,5 +1,6 @@
 
 menu "Fusion MPT device support"
+	depends on PCI
 
 config FUSION
 	bool
diff -urpN linux-2.6/drivers/message/i2o/Kconfig linux-2.6-patched/drivers/message/i2o/Kconfig
--- linux-2.6/drivers/message/i2o/Kconfig	2007-02-04 19:44:54.000000000 +0100
+++ linux-2.6-patched/drivers/message/i2o/Kconfig	2007-04-19 15:49:17.000000000 +0200
@@ -1,5 +1,6 @@
 
 menu "I2O device support"
+	depends on PCI
 
 config I2O
 	tristate "I2O support"

Re: [PATCH 1/8] Kconfig: refine depends statements.

[Arnd Bergmann]

On Friday 20 April 2007, Martin Schwidefsky wrote:
> diff -urpN linux-2.6/drivers/auxdisplay/Kconfig linux-2.6-patched/drivers/auxdisplay/Kconfig
> --- linux-2.6/drivers/auxdisplay/Kconfig        2007-04-19 15:23:55.000000000 +0200
> +++ linux-2.6-patched/drivers/auxdisplay/Kconfig        2007-04-19 15:49:17.000000000 +0200
> @@ -6,6 +6,7 @@
>  #
>  
>  menu "Auxiliary Display support"
> +       depends on PARPORT_PC
>  
>  config KS0108
>         tristate "KS0108 LCD Controller"

I would guess that this actually depends on PARPORT, not PARPORT_PC.

The rest of this patch looks good.

	Arnd <><

Re: [PATCH 1/8] Kconfig: refine depends statements.

[Miguel Ojeda]

On 4/22/07, Arnd Bergmann <arnd@arndb.de> wrote:
>
> I would guess that this actually depends on PARPORT, not PARPORT_PC.
>

In fact it does not depend on any of them. Auxiliary Displays could
use any kind of interface. However, by now we only have one controller
driver (ks0108) through parport (PC); so for the moment the patch
would be OK, although the menu "Auxiliar Displays" is not just about
parport'ed-stuff.

> The rest of this patch looks good.
>
> 	Arnd <><
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

-- 
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm