From: Andi Kleen <ak@suse.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@osdl.org>, Chaz Masden <zamsden@gmail.com>,
Petr Vandrovec <petr@vmware.com>,
virtualization@lists.linux-foundation.org,
Chris Wright <chrisw@sous-sol.org>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [RFC, PATCH 0/5] Paravirt: fix export of paravirt-ops to binary modules
Date: Mon, 23 Apr 2007 02:49:29 +0200 [thread overview]
Message-ID: <200704230249.29473.ak@suse.de> (raw)
In-Reply-To: <1177287845.17026.27.camel@localhost.localdomain>
On Monday 23 April 2007 02:24:05 Rusty Russell wrote:
> On Mon, 2007-04-23 at 01:49 +0200, Andi Kleen wrote:
> > > Less exports good. Consistency with all config options isn't a hard
> > > requirement: I'd be tempted not to export the pte functions.
> >
> > Yes paravirt_ops should be probably split into two for internal and external
> > available functions. Any takers?
>
> Hi Andi!
>
> I'm a little uncomfortable with cutting the struct this way: I always
> thought it'd be a function split if we did one.
It's a functional split, isn't it? arch/mm internal and "exported" to other
users
> With the new patch code we could simply shuffle all the exportables to
> the front and fail to patch calls past this point (then fail the module
> load).
Two structures would seem cleaner to me than such hacks.
-Andi
next prev parent reply other threads:[~2007-04-23 0:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-20 1:52 [RFC, PATCH 0/5] Paravirt: fix export of paravirt-ops to binary modules Zachary Amsden
2007-04-20 9:34 ` Andi Kleen
2007-04-20 15:03 ` Jeremy Fitzhardinge
2007-04-20 21:25 ` Zachary Amsden
2007-04-20 21:33 ` Jeremy Fitzhardinge
2007-04-20 21:36 ` Zachary Amsden
2007-04-20 23:01 ` Jeremy Fitzhardinge
2007-04-20 23:02 ` Zachary Amsden
2007-04-22 23:37 ` Rusty Russell
2007-04-22 23:49 ` Andi Kleen
2007-04-23 0:24 ` Rusty Russell
2007-04-23 0:49 ` Andi Kleen [this message]
2007-04-23 1:04 ` Rusty Russell
2007-04-23 21:18 ` Zachary Amsden
2007-04-23 1:00 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704230249.29473.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=mingo@elte.hu \
--cc=petr@vmware.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
--cc=virtualization@lists.osdl.org \
--cc=zamsden@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.