All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@in.ibm.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: fastboot@osdl.org, Kexec Mailing List <kexec@lists.infradead.org>,
	Jurriaan <thunder7@xs4all.nl>,
	linux-kernel@vger.kernel.org, Magnus Damm <magnus@valinux.co.jp>,
	Helge Hafting <helgehaf@aitel.hist.no>,
	Horms <horms@verge.net.au>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <ak@suse.de>
Subject: Re: [PATCH 2/2] x86_64: Remove CONFIG_PHYSICAL_START and CONFIG_RELOCATABLE
Date: Mon, 23 Apr 2007 11:37:39 +0530	[thread overview]
Message-ID: <20070423060739.GA14664@in.ibm.com> (raw)
In-Reply-To: <m14pn7zn5n.fsf_-_@ebiederm.dsl.xmission.com>

On Sun, Apr 22, 2007 at 11:15:48PM -0600, Eric W. Biederman wrote:
> 
> Now that the vmlinux is marked as relocatable there is no reason to
> retain the CONFIG_PHYSICAL_START option, as we can put the binary we
> have at any 2MB aligned address in memory.
> 
> With CONFIG_PHYSICAL_START gone the handful of code lines that depend
> on CONFIG_RELOCATABLE no longer make sense to be conditional and can
> be removed.
> 
> The big win of this patch (besides Kconfig simplicity) is that the
> nasty BUILD_BUG_ON test for people misaligning their kernel when using
> CONFIG_PHYSICAL_START can be removed as this case can only happen with
> CONFIG_PHYSICAL_START selected.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
> ---
>  arch/x86_64/Kconfig                |   55 +-----------------------------------
>  arch/x86_64/Makefile               |    2 -
>  arch/x86_64/boot/compressed/head.S |   13 +--------
>  arch/x86_64/boot/setup.S           |    4 --
>  arch/x86_64/defconfig              |    2 -
>  arch/x86_64/kernel/head64.c        |    7 ----
>  include/asm-x86_64/page.h          |    2 +-
>  7 files changed, 3 insertions(+), 82 deletions(-)
> 
> diff --git a/arch/x86_64/Kconfig b/arch/x86_64/Kconfig
> index 773b487..713c1ad 100644
> --- a/arch/x86_64/Kconfig
> +++ b/arch/x86_64/Kconfig
> @@ -565,62 +565,9 @@ config CRASH_DUMP
>            which are loaded in the main kernel with kexec-tools into
>            a specially reserved region and then later executed after
>            a crash by kdump/kexec. The crash dump kernel must be compiled
> -	  to a memory address not used by the main kernel or BIOS using
> -	  PHYSICAL_START.
> +	  to a memory address not used by the main kernel or BIOS
>            For more details see Documentation/kdump/kdump.txt

Hi Eric,

I think "must be compiled" should be replaced with "must be loaded" now.

Otherwise both the patches look fine.  I am planning to test these.

This change will also require modifications to Documentation/kdump/kdump.txt
file.

Thanks
Vivek

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@in.ibm.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Andi Kleen <ak@suse.de>, Jurriaan <thunder7@xs4all.nl>,
	Helge Hafting <helgehaf@aitel.hist.no>,
	linux-kernel@vger.kernel.org, Magnus Damm <magnus@valinux.co.jp>,
	Horms <horms@verge.net.au>,
	fastboot@osdl.org, Kexec Mailing List <kexec@lists.infradead.org>
Subject: Re: [PATCH 2/2] x86_64: Remove CONFIG_PHYSICAL_START and CONFIG_RELOCATABLE
Date: Mon, 23 Apr 2007 11:37:39 +0530	[thread overview]
Message-ID: <20070423060739.GA14664@in.ibm.com> (raw)
In-Reply-To: <m14pn7zn5n.fsf_-_@ebiederm.dsl.xmission.com>

On Sun, Apr 22, 2007 at 11:15:48PM -0600, Eric W. Biederman wrote:
> 
> Now that the vmlinux is marked as relocatable there is no reason to
> retain the CONFIG_PHYSICAL_START option, as we can put the binary we
> have at any 2MB aligned address in memory.
> 
> With CONFIG_PHYSICAL_START gone the handful of code lines that depend
> on CONFIG_RELOCATABLE no longer make sense to be conditional and can
> be removed.
> 
> The big win of this patch (besides Kconfig simplicity) is that the
> nasty BUILD_BUG_ON test for people misaligning their kernel when using
> CONFIG_PHYSICAL_START can be removed as this case can only happen with
> CONFIG_PHYSICAL_START selected.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
> ---
>  arch/x86_64/Kconfig                |   55 +-----------------------------------
>  arch/x86_64/Makefile               |    2 -
>  arch/x86_64/boot/compressed/head.S |   13 +--------
>  arch/x86_64/boot/setup.S           |    4 --
>  arch/x86_64/defconfig              |    2 -
>  arch/x86_64/kernel/head64.c        |    7 ----
>  include/asm-x86_64/page.h          |    2 +-
>  7 files changed, 3 insertions(+), 82 deletions(-)
> 
> diff --git a/arch/x86_64/Kconfig b/arch/x86_64/Kconfig
> index 773b487..713c1ad 100644
> --- a/arch/x86_64/Kconfig
> +++ b/arch/x86_64/Kconfig
> @@ -565,62 +565,9 @@ config CRASH_DUMP
>            which are loaded in the main kernel with kexec-tools into
>            a specially reserved region and then later executed after
>            a crash by kdump/kexec. The crash dump kernel must be compiled
> -	  to a memory address not used by the main kernel or BIOS using
> -	  PHYSICAL_START.
> +	  to a memory address not used by the main kernel or BIOS
>            For more details see Documentation/kdump/kdump.txt

Hi Eric,

I think "must be compiled" should be replaced with "must be loaded" now.

Otherwise both the patches look fine.  I am planning to test these.

This change will also require modifications to Documentation/kdump/kdump.txt
file.

Thanks
Vivek

  reply	other threads:[~2007-04-23  6:08 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-30  8:05 2.6.21-rc5-mm3 Andrew Morton
2007-03-30 11:00 ` 2.6.21-rc5-mm3 Rafael J. Wysocki
2007-03-30 16:31 ` 2.6.21-rc5-mm3 Michal Piotrowski
2007-03-30 16:55   ` 2.6.21-rc5-mm3 Ingo Molnar
2007-03-30 17:19     ` 2.6.21-rc5-mm3 Michal Piotrowski
2007-03-30 16:38 ` 2.6.21-rc5-mm3 Dmitry Torokhov
2007-03-30 16:59   ` 2.6.21-rc5-mm3 Andrew Morton
2007-03-30 17:23 ` 2.6.21-rc5-mm3 Valdis.Kletnieks
2007-03-30 18:58   ` 2.6.21-rc5-mm3 Johannes Berg
2007-03-31  7:12 ` 2.6.21-rc5-mm3 - no boot, "address not 2M aligned" Helge Hafting
2007-03-31  7:53   ` Andrew Morton
2007-03-31  8:14     ` Eric W. Biederman
2007-04-09 22:09       ` Helge Hafting
2007-04-10  4:48         ` Helge Hafting
2007-04-01  5:29     ` thunder7
2007-04-01  6:15       ` Eric W. Biederman
2007-04-01  6:29         ` Andrew Morton
2007-04-02  7:41           ` Vivek Goyal
2007-04-02  8:43             ` Eric W. Biederman
2007-04-02  9:45               ` Vivek Goyal
2007-04-02 17:26                 ` Eric W. Biederman
2007-04-03  4:01                   ` Vivek Goyal
2007-04-03  5:23                     ` Eric W. Biederman
2007-04-03 10:03                       ` Vivek Goyal
2007-04-23  5:12                         ` [PATCH 1/2] x86_64: Reflect the relocatability of the kernel in the ELF header Eric W. Biederman
2007-04-23  5:12                           ` Eric W. Biederman
2007-04-23  5:15                           ` [PATCH 2/2] x86_64: Remove CONFIG_PHYSICAL_START and CONFIG_RELOCATABLE Eric W. Biederman
2007-04-23  5:15                             ` Eric W. Biederman
2007-04-23  6:07                             ` Vivek Goyal [this message]
2007-04-23  6:07                               ` Vivek Goyal
2007-04-23  6:17                               ` Eric W. Biederman
2007-04-23  6:17                                 ` Eric W. Biederman
2007-04-23  6:25                                 ` Vivek Goyal
2007-04-23  6:25                                   ` Vivek Goyal
2007-04-24  6:31                           ` [PATCH 1/2] x86_64: Reflect the relocatability of the kernel in the ELF header Vivek Goyal
2007-04-24  6:31                             ` Vivek Goyal
2007-04-24  7:21                             ` Eric W. Biederman
2007-04-24  7:21                               ` Eric W. Biederman
2007-04-02 11:17             ` 2.6.21-rc5-mm3 - no boot, "address not 2M aligned" thunder7
2007-04-02 11:36               ` Vivek Goyal
2007-04-02 14:49                 ` thunder7
2007-04-02 14:59                   ` thunder7
2007-04-03  4:05                     ` Vivek Goyal
2007-03-31  8:05 ` 2.6.21-rc5-mm3 - cpuidle, acpi, and C-states Valdis.Kletnieks
2007-03-31 19:25 ` 2.6.21-rc5-mm3: Why was my vioc cleanup patch dropped? Adrian Bunk
2007-03-31 20:48 ` [-mm patch] make drivers/ata/pata_ali.c:ali_tf_load() static Adrian Bunk
2007-04-01 16:21   ` Tejun Heo
2007-03-31 20:55 ` [2.6 patch] remove the config option for the cs5530a_warm_reset() quirk Adrian Bunk
2007-03-31 21:05   ` Jeremy Fitzhardinge
2007-03-31 21:11     ` Adrian Bunk
2007-03-31 21:17       ` Jeremy Fitzhardinge
2007-03-31 20:55 ` [-mm patch] make drivers/net/qla3xxx.c:PHY_DEVICES[] static Adrian Bunk
2007-04-04  2:34   ` Jeff Garzik
2007-03-31 20:55 ` [-mm patch] make struct proc_fdinfo_file_operations static Adrian Bunk
2007-04-01 16:00 ` 2.6.21-rc5-mm3 Michal Piotrowski
2007-04-01 19:03   ` 2.6.21-rc5-mm3 Andrew Morton
2007-04-01 20:39     ` 2.6.21-rc5-mm3 Rafael J. Wysocki
2007-04-01 20:56       ` 2.6.21-rc5-mm3 Rafael J. Wysocki
2007-04-01 21:59       ` 2.6.21-rc5-mm3 Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070423060739.GA14664@in.ibm.com \
    --to=vgoyal@in.ibm.com \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=fastboot@osdl.org \
    --cc=helgehaf@aitel.hist.no \
    --cc=horms@verge.net.au \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magnus@valinux.co.jp \
    --cc=thunder7@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.