* [PATCH] Nvidia AGP: Use refcount aware PCI interfaces
@ 2007-04-23 13:50 Alan Cox
2007-04-23 14:21 ` Dave Jones
0 siblings, 1 reply; 3+ messages in thread
From: Alan Cox @ 2007-04-23 13:50 UTC (permalink / raw)
To: davej, linux-kernel
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c linux-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c
--- linux.vanilla-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c 2007-04-12 14:15:03.000000000 +0100
+++ linux-2.6.21-rc6-mm1/drivers/char/agp/nvidia-agp.c 2007-04-23 11:53:12.560578080 +0100
@@ -320,11 +320,11 @@
u8 cap_ptr;
nvidia_private.dev_1 =
- pci_find_slot((unsigned int)pdev->bus->number, PCI_DEVFN(0, 1));
+ pci_get_bus_and_slot((unsigned int)pdev->bus->number, PCI_DEVFN(0, 1));
nvidia_private.dev_2 =
- pci_find_slot((unsigned int)pdev->bus->number, PCI_DEVFN(0, 2));
+ pci_get_bus_and_slot((unsigned int)pdev->bus->number, PCI_DEVFN(0, 2));
nvidia_private.dev_3 =
- pci_find_slot((unsigned int)pdev->bus->number, PCI_DEVFN(30, 0));
+ pci_get_bus_and_slot((unsigned int)pdev->bus->number, PCI_DEVFN(30, 0));
if (!nvidia_private.dev_1 || !nvidia_private.dev_2 || !nvidia_private.dev_3) {
printk(KERN_INFO PFX "Detected an NVIDIA nForce/nForce2 "
@@ -443,6 +443,9 @@
static void __exit agp_nvidia_cleanup(void)
{
pci_unregister_driver(&agp_nvidia_pci_driver);
+ pci_dev_put(nvidia_private.dev_1);
+ pci_dev_put(nvidia_private.dev_2);
+ pci_dev_put(nvidia_private.dev_3);
}
module_init(agp_nvidia_init);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Nvidia AGP: Use refcount aware PCI interfaces
2007-04-23 13:50 [PATCH] Nvidia AGP: Use refcount aware PCI interfaces Alan Cox
@ 2007-04-23 14:21 ` Dave Jones
2007-04-23 15:13 ` Alan Cox
0 siblings, 1 reply; 3+ messages in thread
From: Dave Jones @ 2007-04-23 14:21 UTC (permalink / raw)
To: Alan Cox; +Cc: linux-kernel
On Mon, Apr 23, 2007 at 02:50:27PM +0100, Alan Cox wrote:
> Signed-off-by: Alan Cox <alan@redhat.com>
This is lacking a changelog. What's the purpose of changing this?
Is pci_find_slot() obsolete and going away? (If so, it should be
marked as such). These devices aren't hotpluggable, so I'm not
sure why they need to be reference counted.
Inquisitive minds would like to know more.
Dave
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Nvidia AGP: Use refcount aware PCI interfaces
2007-04-23 14:21 ` Dave Jones
@ 2007-04-23 15:13 ` Alan Cox
0 siblings, 0 replies; 3+ messages in thread
From: Alan Cox @ 2007-04-23 15:13 UTC (permalink / raw)
To: Dave Jones; +Cc: linux-kernel
On Mon, 23 Apr 2007 10:21:14 -0400
Dave Jones <davej@redhat.com> wrote:
> On Mon, Apr 23, 2007 at 02:50:27PM +0100, Alan Cox wrote:
> > Signed-off-by: Alan Cox <alan@redhat.com>
>
> This is lacking a changelog. What's the purpose of changing this?
> Is pci_find_slot() obsolete and going away? (If so, it should be
That is the intention because most users of pci_find_slot are unsafe.
Alan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-04-23 15:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-23 13:50 [PATCH] Nvidia AGP: Use refcount aware PCI interfaces Alan Cox
2007-04-23 14:21 ` Dave Jones
2007-04-23 15:13 ` Alan Cox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.