* Prevent softlockup triggering in nvidiafb
@ 2007-04-23 15:36 Dave Jones
2007-04-23 15:55 ` Alan Cox
2007-04-23 16:05 ` Antonino A. Daplas
0 siblings, 2 replies; 5+ messages in thread
From: Dave Jones @ 2007-04-23 15:36 UTC (permalink / raw)
To: Linux Kernel; +Cc: Antonino Daplas
If the chip locks up, we get into a long polling loop,
where the softlockup detector kicks in.
See https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151878
for an example.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.20.noarch/drivers/video/nvidia/nv_accel.c~ 2007-04-23 11:06:12.000000000 -0400
+++ linux-2.6.20.noarch/drivers/video/nvidia/nv_accel.c 2007-04-23 11:07:18.000000000 -0400
@@ -132,6 +132,8 @@ static void NVDmaWait(struct nvidia_par
}
} else
par->dmaFree = dmaGet - par->dmaCurrent - 1;
+
+ touch_softlockup_watchdog();
}
if (!count) {
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: Prevent softlockup triggering in nvidiafb
2007-04-23 15:36 Prevent softlockup triggering in nvidiafb Dave Jones
@ 2007-04-23 15:55 ` Alan Cox
2007-04-23 16:18 ` Dave Jones
2007-04-23 16:05 ` Antonino A. Daplas
1 sibling, 1 reply; 5+ messages in thread
From: Alan Cox @ 2007-04-23 15:55 UTC (permalink / raw)
To: Dave Jones; +Cc: Linux Kernel, Antonino Daplas
On Mon, 23 Apr 2007 11:36:30 -0400
Dave Jones <davej@redhat.com> wrote:
> If the chip locks up, we get into a long polling loop,
> where the softlockup detector kicks in.
> See https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151878
> for an example.
Surely in this situation the softlockup report and trap out is precisely
what should be occurring.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Prevent softlockup triggering in nvidiafb
2007-04-23 15:55 ` Alan Cox
@ 2007-04-23 16:18 ` Dave Jones
2007-04-23 23:06 ` Antonino A. Daplas
0 siblings, 1 reply; 5+ messages in thread
From: Dave Jones @ 2007-04-23 16:18 UTC (permalink / raw)
To: Alan Cox; +Cc: Linux Kernel, Antonino Daplas
On Mon, Apr 23, 2007 at 04:55:05PM +0100, Alan Cox wrote:
> On Mon, 23 Apr 2007 11:36:30 -0400
> Dave Jones <davej@redhat.com> wrote:
>
> > If the chip locks up, we get into a long polling loop,
> > where the softlockup detector kicks in.
> > See https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151878
> > for an example.
>
> Surely in this situation the softlockup report and trap out is precisely
> what should be occurring.
We can't do anything useful with the trace. It already prints out
info that the hardware locked up.
Dave
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Prevent softlockup triggering in nvidiafb
2007-04-23 16:18 ` Dave Jones
@ 2007-04-23 23:06 ` Antonino A. Daplas
0 siblings, 0 replies; 5+ messages in thread
From: Antonino A. Daplas @ 2007-04-23 23:06 UTC (permalink / raw)
To: davej; +Cc: alan, linux-kernel, adaplas
> On Mon, Apr 23, 2007 at 04:55:05PM +0100, Alan Cox wrote:
> > On Mon, 23 Apr 2007 11:36:30 -0400
> > Dave Jones <davej@redhat.com> wrote:
> >
> > > If the chip locks up, we get into a long polling loop,
> > > where the softlockup detector kicks in.
> > > See https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151878
> for an example.
> >
> > Surely in this situation the softlockup report and trap out is
> precisely what should be occurring.
>
> We can't do anything useful with the trace. It already prints out info
> that the hardware locked up.
And when nvidiafb detects a lockup, it will go to safe mode. Better than
rebooting, I think.
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Prevent softlockup triggering in nvidiafb
2007-04-23 15:36 Prevent softlockup triggering in nvidiafb Dave Jones
2007-04-23 15:55 ` Alan Cox
@ 2007-04-23 16:05 ` Antonino A. Daplas
1 sibling, 0 replies; 5+ messages in thread
From: Antonino A. Daplas @ 2007-04-23 16:05 UTC (permalink / raw)
To: davej; +Cc: linux-kernel, adaplas
> If the chip locks up, we get into a long polling loop,
> where the softlockup detector kicks in.
> See https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=151878
> for an example.
Okay. Thanks.
>
> Signed-off-by: Dave Jones <davej@redhat.com>
Acked-by: Antonino Daplas <adaplas@gmail.com>
Tony
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-04-23 23:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-23 15:36 Prevent softlockup triggering in nvidiafb Dave Jones
2007-04-23 15:55 ` Alan Cox
2007-04-23 16:18 ` Dave Jones
2007-04-23 23:06 ` Antonino A. Daplas
2007-04-23 16:05 ` Antonino A. Daplas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.