From: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
To: Oliver Neukum <oneukum@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use mutex instead of semaphore in RocketPort driver
Date: Tue, 24 Apr 2007 20:19:49 +0200 [thread overview]
Message-ID: <20070424181949.GD6798@traven> (raw)
In-Reply-To: <200704241953.04336.oneukum@suse.de>
El Tue, Apr 24, 2007 at 07:53:04PM +0200 Oliver Neukum ha dit:
> Am Dienstag, 24. April 2007 19:49 schrieb Matthias Kaehlcke:
> > @@ -1706,7 +1706,7 @@ static int rp_write(struct tty_struct *tty,
> > if (count <= 0 || rocket_paranoia_check(info, "rp_write"))
> > return 0;
> >
> > - down_interruptible(&info->write_sem);
> > + mutex_lock_interruptible(&info->write_mtx);
>
> This is a bug. It is also present in the current code, but nevertheless
> it is a bug. If you use an interruptible lock, you must be ready to deal
> with interrupts, which are ignored by this code.
i fear i don't have the experience/knowledge to fix this bug, thanks
for your remark.
i'm a bit confused now about the interruptible locks, i thought using
them means that the process will be waked up when receiving a
signal. what role are playing interrupts when using interruptible locks?
--
Matthias Kaehlcke
Linux Application Developer
Barcelona
La libertad es como la mañana. Hay quienes esperan dormidos a que
llegue, pero hay quienes desvelan y caminan la noche para alcanzarla
(Subcomandante Marcos)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
next prev parent reply other threads:[~2007-04-24 18:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 17:49 [PATCH] use mutex instead of semaphore in RocketPort driver Matthias Kaehlcke
2007-04-24 17:53 ` Oliver Neukum
2007-04-24 18:19 ` Matthias Kaehlcke [this message]
[not found] <fa.CH+7gvaumSAVtl/1QOSoYPsXewg@ifi.uio.no>
[not found] ` <fa.NPDKv3GAx73J43g63faobz7IZVo@ifi.uio.no>
[not found] ` <fa.ZWnvY4ypIcIOxuu79yJn6cBDr8M@ifi.uio.no>
2007-04-24 23:53 ` Robert Hancock
2007-04-25 5:06 ` Satyam Sharma
2007-04-25 12:56 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070424181949.GD6798@traven \
--to=matthias.kaehlcke@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.