From: Oliver Neukum <oneukum@suse.de>
To: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] use mutex instead of semaphore in RocketPort driver
Date: Tue, 24 Apr 2007 19:53:04 +0200 [thread overview]
Message-ID: <200704241953.04336.oneukum@suse.de> (raw)
In-Reply-To: <20070424174953.GB6798@traven>
Am Dienstag, 24. April 2007 19:49 schrieb Matthias Kaehlcke:
> @@ -1706,7 +1706,7 @@ static int rp_write(struct tty_struct *tty,
> if (count <= 0 || rocket_paranoia_check(info, "rp_write"))
> return 0;
>
> - down_interruptible(&info->write_sem);
> + mutex_lock_interruptible(&info->write_mtx);
This is a bug. It is also present in the current code, but nevertheless
it is a bug. If you use an interruptible lock, you must be ready to deal
with interrupts, which are ignored by this code.
Regards
Oliver
next prev parent reply other threads:[~2007-04-24 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-24 17:49 [PATCH] use mutex instead of semaphore in RocketPort driver Matthias Kaehlcke
2007-04-24 17:53 ` Oliver Neukum [this message]
2007-04-24 18:19 ` Matthias Kaehlcke
[not found] <fa.CH+7gvaumSAVtl/1QOSoYPsXewg@ifi.uio.no>
[not found] ` <fa.NPDKv3GAx73J43g63faobz7IZVo@ifi.uio.no>
[not found] ` <fa.ZWnvY4ypIcIOxuu79yJn6cBDr8M@ifi.uio.no>
2007-04-24 23:53 ` Robert Hancock
2007-04-25 5:06 ` Satyam Sharma
2007-04-25 12:56 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200704241953.04336.oneukum@suse.de \
--to=oneukum@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias.kaehlcke@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.