All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: "Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>
Cc: vgoyal@in.ibm.com, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, horms@verge.net.au,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	mbligh@google.com, Keith Owens <kaos@ocs.com.au>,
	akpm@linux-foundation.org
Subject: Re: [PATCH 10/10] Use safe_apic_wait_icr_idle in __send_IPI_dest_field - x86_64
Date: Wed, 25 Apr 2007 14:33:40 +0200	[thread overview]
Message-ID: <200704251433.40302.ak@suse.de> (raw)
In-Reply-To: <1177501872.17974.56.camel@sebastian.intellilink.co.jp>

On Wednesday 25 April 2007 13:51:12 Fernando Luis Vázquez Cao wrote:
> Use safe_apic_wait_icr_idle to check ICR idle bit if the vector is
> NMI_VECTOR to avoid potential hangups in the event of crash when kdump
> tries to stop the other CPUs.

But what happens then when this fails? Won't this give another hang?
Have you tested this?

I applied the patches for now.

-Andi

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: "Fernando Luis Vázquez Cao" <fernando@oss.ntt.co.jp>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
	horms@verge.net.au, kexec@lists.infradead.org,
	linux-kernel@vger.kernel.org, vgoyal@in.ibm.com,
	mbligh@google.com, Keith Owens <kaos@ocs.com.au>,
	akpm@linux-foundation.org
Subject: Re: [PATCH 10/10] Use safe_apic_wait_icr_idle in __send_IPI_dest_field - x86_64
Date: Wed, 25 Apr 2007 14:33:40 +0200	[thread overview]
Message-ID: <200704251433.40302.ak@suse.de> (raw)
In-Reply-To: <1177501872.17974.56.camel@sebastian.intellilink.co.jp>

On Wednesday 25 April 2007 13:51:12 Fernando Luis Vázquez Cao wrote:
> Use safe_apic_wait_icr_idle to check ICR idle bit if the vector is
> NMI_VECTOR to avoid potential hangups in the event of crash when kdump
> tries to stop the other CPUs.

But what happens then when this fails? Won't this give another hang?
Have you tested this?

I applied the patches for now.

-Andi

  reply	other threads:[~2007-04-25 12:34 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-25 11:03 [RFC PATCH 0/10] apic_wait_icr_idle issues and possible solutions Fernando Luis Vázquez Cao
2007-04-25 11:03 ` Fernando Luis Vázquez Cao
2007-04-25 11:13 ` [PATCH 1/10] safe_apic_wait_icr_idle - i386 Fernando Luis Vázquez Cao
2007-04-25 11:13   ` Fernando Luis Vázquez Cao
2007-04-25 12:55   ` Keith Owens
2007-04-25 12:55     ` Keith Owens
2007-04-25 12:59     ` Fernando Luis Vázquez Cao
2007-04-25 12:59       ` Fernando Luis Vázquez Cao
2007-04-25 13:16     ` Andi Kleen
2007-04-25 13:16       ` Andi Kleen
2007-04-25 11:15 ` [PATCH 2/10] safe_apic_wait_icr_idle - x86_64 Fernando Luis Vázquez Cao
2007-04-25 11:15   ` Fernando Luis Vázquez Cao
2007-04-25 12:26   ` Andi Kleen
2007-04-25 12:26     ` Andi Kleen
2007-04-25 12:55     ` Fernando Luis Vázquez Cao
2007-04-25 12:55       ` Fernando Luis Vázquez Cao
2007-04-25 13:11       ` Andi Kleen
2007-04-25 13:11         ` Andi Kleen
2007-04-25 13:32         ` Fernando Luis Vázquez Cao
2007-04-25 13:32           ` Fernando Luis Vázquez Cao
2007-04-25 11:19 ` [PATCH 3/10] smpboot: use safe_apic_wait_icr_idle - i386 Fernando Luis Vázquez Cao
2007-04-25 11:19   ` Fernando Luis Vázquez Cao
2007-04-25 11:21 ` [PATCH 4/10] smpboot: use safe_apic_wait_icr_idle - x86_64 Fernando Luis Vázquez Cao
2007-04-25 11:21   ` Fernando Luis Vázquez Cao
2007-04-25 11:26 ` [PATCH 5/10] __inquire_remote_apic: use safe_apic_wait_icr_idle - i386 Fernando Luis Vázquez Cao
2007-04-25 11:26   ` Fernando Luis Vázquez Cao
2007-04-25 11:27 ` [PATCH 6/10] inquire_remote_apic: use safe_apic_wait_icr_idle - x86_64 Fernando Luis Vázquez Cao
2007-04-25 11:27   ` Fernando Luis Vázquez Cao
2007-04-25 11:37 ` [PATCH 7/10] __send_IPI_dest_field - i386 Fernando Luis Vázquez Cao
2007-04-25 11:37   ` Fernando Luis Vázquez Cao
2007-04-25 11:39 ` [PATCH 8/10] __send_IPI_dest_field - x86_64 Fernando Luis Vázquez Cao
2007-04-25 11:39   ` Fernando Luis Vázquez Cao
2007-04-25 11:49 ` [PATCH 9/10] Use safe_apic_wait_icr_idle in safe_apic_wait_icr_idle - i386 Fernando Luis Vázquez Cao
2007-04-25 11:49   ` Fernando Luis Vázquez Cao
2007-04-25 11:51 ` [PATCH 10/10] Use safe_apic_wait_icr_idle in __send_IPI_dest_field - x86_64 Fernando Luis Vázquez Cao
2007-04-25 11:51   ` Fernando Luis Vázquez Cao
2007-04-25 12:33   ` Andi Kleen [this message]
2007-04-25 12:33     ` Andi Kleen
2007-04-25 12:52     ` Fernando Luis Vázquez Cao
2007-04-25 12:52       ` Fernando Luis Vázquez Cao
2007-04-26  6:48 ` [RFC PATCH 0/10] apic_wait_icr_idle issues and possible solutions Vivek Goyal
2007-04-26  6:48   ` Vivek Goyal
2007-04-26  7:20   ` Fernando Luis Vázquez Cao
2007-04-26  7:20     ` Fernando Luis Vázquez Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200704251433.40302.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=fernando@oss.ntt.co.jp \
    --cc=horms@verge.net.au \
    --cc=kaos@ocs.com.au \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@google.com \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.