Linux 2.6.20.8

Linux 2.6.20.8

[Greg KH]

We (the -stable team) are announcing the release of the 2.6.20.8 kernel.
This release has a security bugfix so any users of kernels older than
2.6.20.7 are highly encouraged to upgrade as soon as possible.

The diffstat and short summary of the fixes are below.

I'll also be replying to this message with a copy of the patch between
2.6.20.7 and 2.6.20.8.

The updated 2.6.20.y git tree can be found at:
        git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-2.6.20.y.git
and can be browsed at the normal kernel.org git web browser:
        www.kernel.org/git/

thanks,

greg k-h

--------
 Makefile                |    2 +-
 net/ipv4/fib_frontend.c |    8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)


Summary of changes from v2.6.20.7 to v2.6.20.8
==============================================

Alexey Kuznetsov (1):
      NETLINK: Infinite recursion in netlink.

Greg Kroah-Hartman (1):
      Linux 2.6.20.8

Re: Linux 2.6.20.8

[Greg KH]

diff --git a/Makefile b/Makefile
index bc99522..f3539e8 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
 VERSION = 2
 PATCHLEVEL = 6
 SUBLEVEL = 20
-EXTRAVERSION = .7
+EXTRAVERSION = .8
 NAME = Homicidal Dwarf Hamster
 
 # *DOCUMENTATION*
diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c
index d47b72a..fa2cb8c 100644
--- a/net/ipv4/fib_frontend.c
+++ b/net/ipv4/fib_frontend.c
@@ -772,6 +772,8 @@ static void nl_fib_lookup(struct fib_result_nl *frn, struct fib_table *tb )
 				       .nl_u = { .ip4_u = { .daddr = frn->fl_addr,
 							    .tos = frn->fl_tos,
 							    .scope = frn->fl_scope } } };
+
+	frn->err = -ENOENT;
 	if (tb) {
 		local_bh_disable();
 
@@ -783,6 +785,7 @@ static void nl_fib_lookup(struct fib_result_nl *frn, struct fib_table *tb )
 			frn->nh_sel = res.nh_sel;
 			frn->type = res.type;
 			frn->scope = res.scope;
+			fib_res_put(&res);
 		}
 		local_bh_enable();
 	}
@@ -797,6 +800,9 @@ static void nl_fib_input(struct sock *sk, int len)
 	struct fib_table *tb;
 	
 	skb = skb_dequeue(&sk->sk_receive_queue);
+	if (skb == NULL)
+		return;
+
 	nlh = (struct nlmsghdr *)skb->data;
 	if (skb->len < NLMSG_SPACE(0) || skb->len < nlh->nlmsg_len ||
 	    nlh->nlmsg_len < NLMSG_LENGTH(sizeof(*frn))) {
@@ -809,7 +815,7 @@ static void nl_fib_input(struct sock *sk, int len)
 
 	nl_fib_lookup(frn, tb);
 	
-	pid = nlh->nlmsg_pid;           /*pid of sending process */
+	pid = NETLINK_CB(skb).pid;       /* pid of sending process */
 	NETLINK_CB(skb).pid = 0;         /* from kernel */
 	NETLINK_CB(skb).dst_group = 0;  /* unicast */
 	netlink_unicast(sk, skb, pid, MSG_DONTWAIT);

Re: Linux 2.6.20.8

[David Miller]

From: Greg KH <gregkh@suse.de>
Date: Wed, 25 Apr 2007 14:22:25 -0700

> We (the -stable team) are announcing the release of the 2.6.20.8 kernel.
> This release has a security bugfix so any users of kernels older than
> 2.6.20.7 are highly encouraged to upgrade as soon as possible.

Greg, Yoshifuji sent you an ipv6 security fix of nearly
equally severity yesterday.

Why did you leave that out?

Re: Linux 2.6.20.8

[Greg KH]

On Wed, Apr 25, 2007 at 04:29:44PM -0700, David Miller wrote:
> From: Greg KH <gregkh@suse.de>
> Date: Wed, 25 Apr 2007 14:22:25 -0700
> 
> > We (the -stable team) are announcing the release of the 2.6.20.8 kernel.
> > This release has a security bugfix so any users of kernels older than
> > 2.6.20.7 are highly encouraged to upgrade as soon as possible.
> 
> Greg, Yoshifuji sent you an ipv6 security fix of nearly
> equally severity yesterday.
> 
> Why did you leave that out?

Because I haven't been applying any network-related patches unless you
forward them to me, based on what happened the last time I did that
without asking :)

So, sorry, I didn't realize this was a big issue, can you forward the
needed patches to me?  I'll do a new release with them in it after I get
back from dinner.

thanks,

greg k-h

Re: Linux 2.6.20.8

[David Miller]

From: Greg KH <gregkh@suse.de>
Date: Wed, 25 Apr 2007 16:52:10 -0700

> Because I haven't been applying any network-related patches unless you
> forward them to me, based on what happened the last time I did that
> without asking :)

:-)  I'm trying not to be too controlling and stay out of the way
every once in a while :)

> So, sorry, I didn't realize this was a big issue, can you forward the
> needed patches to me?  I'll do a new release with them in it after I get
> back from dinner.

I'll send it to you under seperate cover, thanks a lot Greg.