Re: [PATCH v2] [2.6.22] pasemi: cpufreq driver

[olof@lixom.net (Olof Johansson)]

On Thu, Apr 26, 2007 at 09:05:59PM +0200, Segher Boessenkool wrote:
> >>Unfortunately the setting of the current active state is done to an 
> >>SDC
> >>register, while information of the states is in the PMU, so access to
> >>both is needed in the driver.
> >
> >One thing that you could do is to list only this one register of the
> >SDC in the reg property, not all of the SDC.
> 
> The system-controller node should really describe
> all of the system controller.  If the Linux driver
> needs to access two separate devices, it should
> really just do that.  Don't try to make things
> "simpler" in the device tree.
> 
> You probably should map the SDC registers in the
> platform startop code, and then have the various
> platform drivers use that.  Maybe even do an
> abstraction ;-)

Yep, it's a good idea to do and I'll look at it for 2.6.23 time frame.


Thanks,

-Olof