From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-kernel@vger.kernel.org
Subject: [RFC: 2.6 patch] drivers/mtd/maps/nettel.c: possible cleanups
Date: Fri, 27 Apr 2007 01:47:56 +0200 [thread overview]
Message-ID: <20070426234756.GM3468@stusta.de> (raw)
This patch contains the following possible cleanups:
- make 2 needlessly global functions static
- #if 0 the unused nettel_eraseconfig()
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch has been sent on:
- 27 Mar 2007
drivers/mtd/maps/nettel.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
--- linux-2.6.21-rc4-mm1/drivers/mtd/maps/nettel.c.old 2007-03-26 16:04:25.000000000 +0200
+++ linux-2.6.21-rc4-mm1/drivers/mtd/maps/nettel.c 2007-03-26 16:09:39.000000000 +0200
@@ -158,6 +158,8 @@
nettel_reboot_notifier, NULL, 0
};
+#if 0
+
/*
* Erase the configuration file system.
* Used to support the software reset button.
@@ -208,18 +210,22 @@
return(0);
}
+#endif /* 0 */
+
#else
+#if 0
int nettel_eraseconfig(void)
{
return(0);
}
+#endif /* 0 */
#endif
/****************************************************************************/
-int __init nettel_init(void)
+static int __init nettel_init(void)
{
volatile unsigned long *amdpar;
unsigned long amdaddr, maxsize;
@@ -477,7 +483,7 @@
/****************************************************************************/
-void __exit nettel_cleanup(void)
+static void __exit nettel_cleanup(void)
{
#ifdef CONFIG_MTD_CFI_INTELEXT
unregister_reboot_notifier(&nettel_notifier_block);
WARNING: multiple messages have this Message-ID (diff)
From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: dwmw2@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [RFC: 2.6 patch] drivers/mtd/maps/nettel.c: possible cleanups
Date: Fri, 27 Apr 2007 01:47:56 +0200 [thread overview]
Message-ID: <20070426234756.GM3468@stusta.de> (raw)
This patch contains the following possible cleanups:
- make 2 needlessly global functions static
- #if 0 the unused nettel_eraseconfig()
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch has been sent on:
- 27 Mar 2007
drivers/mtd/maps/nettel.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
--- linux-2.6.21-rc4-mm1/drivers/mtd/maps/nettel.c.old 2007-03-26 16:04:25.000000000 +0200
+++ linux-2.6.21-rc4-mm1/drivers/mtd/maps/nettel.c 2007-03-26 16:09:39.000000000 +0200
@@ -158,6 +158,8 @@
nettel_reboot_notifier, NULL, 0
};
+#if 0
+
/*
* Erase the configuration file system.
* Used to support the software reset button.
@@ -208,18 +210,22 @@
return(0);
}
+#endif /* 0 */
+
#else
+#if 0
int nettel_eraseconfig(void)
{
return(0);
}
+#endif /* 0 */
#endif
/****************************************************************************/
-int __init nettel_init(void)
+static int __init nettel_init(void)
{
volatile unsigned long *amdpar;
unsigned long amdaddr, maxsize;
@@ -477,7 +483,7 @@
/****************************************************************************/
-void __exit nettel_cleanup(void)
+static void __exit nettel_cleanup(void)
{
#ifdef CONFIG_MTD_CFI_INTELEXT
unregister_reboot_notifier(&nettel_notifier_block);
next reply other threads:[~2007-04-26 23:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-26 23:47 Adrian Bunk [this message]
2007-04-26 23:47 ` [RFC: 2.6 patch] drivers/mtd/maps/nettel.c: possible cleanups Adrian Bunk
2007-04-27 22:35 ` David Woodhouse
-- strict thread matches above, loose matches on Subject: below --
2007-03-27 1:02 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070426234756.GM3468@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@linux-foundation.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.