From: Dave Jones <davej@redhat.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] cpufreq: do not declare undefined functions
Date: Mon, 30 Apr 2007 15:35:53 -0400 [thread overview]
Message-ID: <20070430193553.GF9385@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0704301208100.16297@chino.kir.corp.google.com>
On Mon, Apr 30, 2007 at 12:10:45PM -0700, David Rientjes wrote:
> On Mon, 30 Apr 2007, Dave Jones wrote:
>
> > > > it's just a prototype, so no code is generated by declaring one
> > > > to an unused (or even non-existant) function.
> > > >
> > > > Or are you using some oddball compiler that warns about this?
> > > >
> > >
> > > If you consider gcc to be oddball, yes.
> >
> > what version ? Mine doesn't seem to warn on that.
> >
> 4.1.2
>
> arch/i386/kernel/cpu/cpufreq/powernow-k8.h:218: warning: 'fill_powernow_table_pstate' declared 'static' but never defined
> arch/i386/kernel/cpu/cpufreq/powernow-k8.h:219: warning: 'fill_powernow_table_fidvid' declared 'static' but never defined
>
> Make sure CONFIG_X86_POWERNOW_K8=y and CONFIG_X86_POWERNOW_K8_ACPI=n.
Ah, I had ACPI_PROCESSOR=y, which was flipping it back on after I'd changed it.
Ok. Thanks.
Dave
--
http://www.codemonkey.org.uk
prev parent reply other threads:[~2007-04-30 19:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-30 14:34 [patch] cpufreq: do not declare undefined functions David Rientjes
2007-04-30 15:59 ` Dave Jones
2007-04-30 18:42 ` David Rientjes
2007-04-30 18:52 ` Dave Jones
2007-04-30 19:10 ` David Rientjes
2007-04-30 19:35 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070430193553.GF9385@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.