From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: update-grub2 patch
Date: Tue, 1 May 2007 22:45:39 +0200 [thread overview]
Message-ID: <200705012245.39321.okuji@enbug.org> (raw)
In-Reply-To: <20070429232251.GA2611@aragorn>
On Monday 30 April 2007 01:22, Robert Millan wrote:
> On Sat, Apr 21, 2007 at 03:38:38PM +0200, Yoshinori K. Okuji wrote:
> > On Tuesday 17 April 2007 14:49, Robert Millan wrote:
> > > Here's my patch. Let me know if it's ok for commit.
> >
> > To include this in the official repository, you need to take care about
> > the portability. [...]
>
> I ported it to bourne shell. It's tested and known to work with dash as
> /bin/sh. I think this should address your concern.
>
> My new patch also arranges the logic for generating update-grub components
> to make it more similar to how grub-install is handled.
Some issues are still there. You should avoid test -z. Instead, use test x$foo
= x. You should avoid ! in test. Use else instead. You should avoid using
which. Travese $PATH instead.
Okuji
next prev parent reply other threads:[~2007-05-01 20:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-15 10:18 update-grub2 Robert Millan
2006-10-15 10:40 ` update-grub2 Declan Naughton
2006-10-15 11:16 ` update-grub2 Robert Millan
[not found] ` <8764elkryd.fsf@neumann.lab.ossystems.com.br>
2006-10-16 13:48 ` update-grub2 Robert Millan
2006-11-27 17:00 ` ping (update-grub2) Robert Millan
2006-11-27 22:20 ` Vincent Pelletier
2007-04-11 15:57 ` update-grub again (Re: ping (update-grub2)) Robert Millan
[not found] ` <20061127214807.GA23613@linkinnovations.com>
2006-11-28 6:32 ` ping (update-grub2) Robert Millan
2006-11-28 7:26 ` Yoshinori K. Okuji
2007-04-11 15:50 ` update-grub again (Re: ping (update-grub2)) Robert Millan
2007-04-17 12:49 ` update-grub2 patch Robert Millan
2007-04-17 13:26 ` Otavio Salvador
2007-04-21 13:38 ` Yoshinori K. Okuji
2007-04-29 23:22 ` Robert Millan
2007-05-01 20:45 ` Yoshinori K. Okuji [this message]
2007-05-02 13:31 ` Robert Millan
2007-05-02 15:35 ` Amin Azez
2007-05-03 15:48 ` Robert Millan
2007-05-03 21:44 ` Yoshinori K. Okuji
2007-05-04 7:14 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705012245.39321.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.