From: Glauber de Oliveira Costa <gcosta@redhat.com>
To: Andi Kleen <ak@novell.com>
Cc: Mark Lord <lkml@rtr.ca>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Remove unnecessary irq disabling
Date: Wed, 2 May 2007 13:13:56 -0300 [thread overview]
Message-ID: <20070502161356.GA8485@redhat.com> (raw)
In-Reply-To: <200705021158.17759.ak@novell.com>
On Wed, May 02, 2007 at 11:58:17AM +0200, Andi Kleen wrote:
>
> > > What does that break, or was it already broken and this fixes it?
> > I think neither. This function is only called at early bootup,
> > (start_secondary() ), and most of its callees have interrupts off anyway.
> > But maybe we do lose something. Andi, do you have a word on this?
>
> We need to enable them somewhere, but cpu_idle will do it in the end.
> So it should be safe to drop it. I guess keeping them disabled the whole
> time will be a little safer against potential races.
yeah, that's exactly what I've thought. We enable interrupts (to disable
them afterwards) in smp_callin(), to avoid waking up Mr. Watchdog. I
guess it won't be a problem after that, will it?
--
Glauber de Oliveira Costa
Red Hat Inc.
"Free as in Freedom"
prev parent reply other threads:[~2007-05-02 18:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-01 21:30 [PATCH] Remove unnecessary irq disabling Glauber de Oliveira Costa
2007-05-01 23:59 ` Mark Lord
2007-05-02 4:44 ` Glauber de Oliveira Costa
2007-05-02 9:58 ` Andi Kleen
2007-05-02 12:27 ` Mark Lord
2007-05-02 16:13 ` Glauber de Oliveira Costa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070502161356.GA8485@redhat.com \
--to=gcosta@redhat.com \
--cc=ak@novell.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@rtr.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.