Re: [PATCH] Remove unnecessary irq disabling

[Mark Lord <lkml@rtr.ca>]

Glauber de Oliveira Costa wrote:
> RR asks us if it is really necessary to disable interrupts in
> setup_secondary_APIC_clock(). The answer is no, since setup_APIC_timer()
> starts by saving irq flags, which also disables them.
> 
> Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
> 
> --- a/arch/x86_64/kernel/apic.c
> +++ b/arch/x86_64/kernel/apic.c
> @@ -875,9 +875,7 @@ void __init setup_boot_APIC_clock (void)
>  
>  void __cpuinit setup_secondary_APIC_clock(void)
>  {
> -	local_irq_disable(); /* FIXME: Do we need this? --RR */
>  	setup_APIC_timer(calibration_result);
> -	local_irq_enable();
>  }
>  
>  void disable_APIC_timer(void)

Okay, I'll bite:  before the patch, this code would exit
with interrupts *enabled*, always.   Now it does not.

What does that break, or was it already broken and this fixes it?

Cheers