+ kcopyd-use-mutex-instead-of-semaphore.patch added to -mm tree

+ kcopyd-use-mutex-instead-of-semaphore.patch added to -mm tree

[akpm]

The patch titled
     Kcopyd: use mutex instead of semaphore
has been added to the -mm tree.  Its filename is
     kcopyd-use-mutex-instead-of-semaphore.patch

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: Kcopyd: use mutex instead of semaphore
From: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>

Kcopyd uses a semaphore as mutex.  Use the mutex API instead of the (binary)
semaphore,

Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
Cc: Neil Brown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/md/kcopyd.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff -puN drivers/md/kcopyd.c~kcopyd-use-mutex-instead-of-semaphore drivers/md/kcopyd.c
--- a/drivers/md/kcopyd.c~kcopyd-use-mutex-instead-of-semaphore
+++ a/drivers/md/kcopyd.c
@@ -198,7 +198,7 @@ struct kcopyd_job {
 	 * These fields are only used if the job has been split
 	 * into more manageable parts.
 	 */
-	struct semaphore lock;
+	struct mutex lock;
 	atomic_t sub_jobs;
 	sector_t progress;
 };
@@ -459,7 +459,7 @@ static void segment_complete(int read_er
 	sector_t count = 0;
 	struct kcopyd_job *job = (struct kcopyd_job *) context;
 
-	down(&job->lock);
+	mutex_lock(&job->lock);
 
 	/* update the error */
 	if (read_err)
@@ -483,7 +483,7 @@ static void segment_complete(int read_er
 			job->progress += count;
 		}
 	}
-	up(&job->lock);
+	mutex_unlock(&job->lock);
 
 	if (count) {
 		int i;
@@ -565,7 +565,7 @@ int kcopyd_copy(struct kcopyd_client *kc
 		dispatch_job(job);
 
 	else {
-		init_MUTEX(&job->lock);
+		mutex_init(&job->lock);
 		job->progress = 0;
 		split_job(job);
 	}
_

Patches currently in -mm which might be from matthias.kaehlcke@gmail.com are

origin.patch
include-kern_-constant-in-printk-calls-in-mm-slabc.patch
srmcons-fix-kmallocgfp_kernel-inside-spinlock.patch
power-management-use-mutexes-instead-of-semaphores.patch
sysdev-use-mutex-instead-of-semaphore.patch
git-dvb.patch
use-mutex-instead-of-binary-semaphore-in-idt77252-driver.patch
qla1280-use-dma_64bit_mask-instead-of-0ull.patch
use-mutex-instead-of-binary-semaphore-in-cdu-31a-driver.patch
use-mutex-instead-of-semaphore-in-sbpcd-driver.patch
use-mutex-instead-of-semaphore-in-berkshire-usb-pc-watchdog-driver.patch
use-mutex-instead-of-semaphore-in-rocketport-driver.patch
use-mutex-instead-of-semaphore-in-tpm-driver.patch
use-mutex-instead-of-semaphore-in-hdaps-driver.patch
use-mutex-instead-of-semaphore-for-misc-char-devices.patch
fix-spinlock-usage-in-hysdn_log_close.patch
use-mutex-instead-of-semaphore-in-capi-20-interface.patch
use-mutex-instead-of-semaphore-in-virtual-console-driver.patch
kcopyd-use-mutex-instead-of-semaphore.patch
pvrusb2-use-mutex-instead-of-semaphore.patch
scx200-use-mutex-instead-of-semaphore.patch

Re: + kcopyd-use-mutex-instead-of-semaphore.patch added to -mm tree

[Neil Brown]

Should be
  Cc: dm-devel@redhat.com

Maybe there should be a Cc: line in the top of each file??

Thanks,
NeilBrown


On Thursday May 3, akpm@linux-foundation.org wrote:
> 
> The patch titled
>      Kcopyd: use mutex instead of semaphore
> has been added to the -mm tree.  Its filename is
>      kcopyd-use-mutex-instead-of-semaphore.patch
> 
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> 
> See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
> out what to do about this
> 
> ------------------------------------------------------
> Subject: Kcopyd: use mutex instead of semaphore
> From: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
> 
> Kcopyd uses a semaphore as mutex.  Use the mutex API instead of the (binary)
> semaphore,
> 
> Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>
> Cc: Neil Brown <neilb@suse.de>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/md/kcopyd.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff -puN drivers/md/kcopyd.c~kcopyd-use-mutex-instead-of-semaphore drivers/md/kcopyd.c
> --- a/drivers/md/kcopyd.c~kcopyd-use-mutex-instead-of-semaphore
> +++ a/drivers/md/kcopyd.c
> @@ -198,7 +198,7 @@ struct kcopyd_job {
>  	 * These fields are only used if the job has been split
>  	 * into more manageable parts.
>  	 */
> -	struct semaphore lock;
> +	struct mutex lock;
>  	atomic_t sub_jobs;
>  	sector_t progress;
>  };
> @@ -459,7 +459,7 @@ static void segment_complete(int read_er
>  	sector_t count = 0;
>  	struct kcopyd_job *job = (struct kcopyd_job *) context;
>  
> -	down(&job->lock);
> +	mutex_lock(&job->lock);
>  
>  	/* update the error */
>  	if (read_err)
> @@ -483,7 +483,7 @@ static void segment_complete(int read_er
>  			job->progress += count;
>  		}
>  	}
> -	up(&job->lock);
> +	mutex_unlock(&job->lock);
>  
>  	if (count) {
>  		int i;
> @@ -565,7 +565,7 @@ int kcopyd_copy(struct kcopyd_client *kc
>  		dispatch_job(job);
>  
>  	else {
> -		init_MUTEX(&job->lock);
> +		mutex_init(&job->lock);
>  		job->progress = 0;
>  		split_job(job);
>  	}
> _
> 
> Patches currently in -mm which might be from matthias.kaehlcke@gmail.com are
> 
> origin.patch
> include-kern_-constant-in-printk-calls-in-mm-slabc.patch
> srmcons-fix-kmallocgfp_kernel-inside-spinlock.patch
> power-management-use-mutexes-instead-of-semaphores.patch
> sysdev-use-mutex-instead-of-semaphore.patch
> git-dvb.patch
> use-mutex-instead-of-binary-semaphore-in-idt77252-driver.patch
> qla1280-use-dma_64bit_mask-instead-of-0ull.patch
> use-mutex-instead-of-binary-semaphore-in-cdu-31a-driver.patch
> use-mutex-instead-of-semaphore-in-sbpcd-driver.patch
> use-mutex-instead-of-semaphore-in-berkshire-usb-pc-watchdog-driver.patch
> use-mutex-instead-of-semaphore-in-rocketport-driver.patch
> use-mutex-instead-of-semaphore-in-tpm-driver.patch
> use-mutex-instead-of-semaphore-in-hdaps-driver.patch
> use-mutex-instead-of-semaphore-for-misc-char-devices.patch
> fix-spinlock-usage-in-hysdn_log_close.patch
> use-mutex-instead-of-semaphore-in-capi-20-interface.patch
> use-mutex-instead-of-semaphore-in-virtual-console-driver.patch
> kcopyd-use-mutex-instead-of-semaphore.patch
> pvrusb2-use-mutex-instead-of-semaphore.patch
> scx200-use-mutex-instead-of-semaphore.patch

Re: + kcopyd-use-mutex-instead-of-semaphore.patch added to -mm tree

[Andrew Morton]

On Fri, 4 May 2007 16:25:09 +1000 Neil Brown <neilb@suse.de> wrote:

> Should be
>   Cc: dm-devel@redhat.com

drat.

> Maybe there should be a Cc: line in the top of each file??

I've thought about that sometimes.  I end up adding a lot of cc's.

I _could_ just do a reverse lookup on my patches directory and work out
who I cc'ed last time on that file.

A git-whatchanged|grep would be a more accurate way.  A bit spammy though.

I have it all in my head ;)

Re: + kcopyd-use-mutex-instead-of-semaphore.patch added to -mm tree

[Neil Brown]

[-- Attachment #1: message body text --]
[-- Type: text/plain, Size: 115 bytes --]

On Thursday May 3, akpm@linux-foundation.org wrote:
> 
> I have it all in my head ;)

I think your brain is full.


[-- Attachment #2: Mr Osborne, may I be excused? My brain is full. --]
[-- Type: image/gif, Size: 16809 bytes --]

[-- Attachment #3: message body text --]
[-- Type: text/plain, Size: 11 bytes --]


NeilBrown

[-- Attachment #4: Type: text/plain, Size: 0 bytes --]