All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>,
	Greg KH <gregkh@suse.de>,
	linux-pm@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] suspend/resume debugging: device filter
Date: Sat, 5 May 2007 12:08:55 +0200	[thread overview]
Message-ID: <20070505100855.GC25704@elf.ucw.cz> (raw)
In-Reply-To: <20070505092425.GA23125@elte.hu>

Hi!

> > Here's a (compile tested only) patch that does this on a per-device 
> > basis, which is smaller, and should work just as well as your patch.
> > 
> > It creates a new file in the power/ directory for every device called 
> > "can_suspend".  Write a '0' to it to prevent that device from being 
> > suspended.
> > 
> > Does this work for you?
> 
> yeah, i was able to use this too to debug suspend/resume problems. But 
> i've added the check to the resume path too - for example sw-suspend 
> does a resume of devices during its suspend cycle, cutting off much of 
> the netconsole output.
> 
> which makes the can_suspend flag mis-named - perhaps rename it to 
> exclude_pm ?

debug_exclude_pm? I do not want people playing with it, then
complaining that they broke the suspend.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Ingo Molnar <mingo@elte.hu>
Cc: Greg KH <gregkh@suse.de>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>,
	linux-pm@lists.osdl.org
Subject: Re: [patch] suspend/resume debugging: device filter
Date: Sat, 5 May 2007 12:08:55 +0200	[thread overview]
Message-ID: <20070505100855.GC25704@elf.ucw.cz> (raw)
In-Reply-To: <20070505092425.GA23125@elte.hu>

Hi!

> > Here's a (compile tested only) patch that does this on a per-device 
> > basis, which is smaller, and should work just as well as your patch.
> > 
> > It creates a new file in the power/ directory for every device called 
> > "can_suspend".  Write a '0' to it to prevent that device from being 
> > suspended.
> > 
> > Does this work for you?
> 
> yeah, i was able to use this too to debug suspend/resume problems. But 
> i've added the check to the resume path too - for example sw-suspend 
> does a resume of devices during its suspend cycle, cutting off much of 
> the netconsole output.
> 
> which makes the can_suspend flag mis-named - perhaps rename it to 
> exclude_pm ?

debug_exclude_pm? I do not want people playing with it, then
complaining that they broke the suspend.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2007-05-05 10:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-25 11:05 [patch] suspend/resume debugging: device filter Ingo Molnar
2007-01-25 11:28 ` Nigel Cunningham
2007-01-25 11:32 ` Pavel Machek
2007-01-26  1:55 ` Greg KH
2007-01-26  1:55   ` Greg KH
2007-01-26  9:36   ` Pavel Machek
2007-01-26  9:36     ` Pavel Machek
2007-05-05  9:24   ` Ingo Molnar
2007-05-05  9:39     ` Rafael J. Wysocki
2007-05-05 10:08     ` Pavel Machek [this message]
2007-05-05 10:08       ` Pavel Machek
2007-05-08  2:54       ` [linux-pm] " Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070505100855.GC25704@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.