* [PATCH] fix ipt_IDLETIMER.c compilation
[not found] <20070508210138.371687586@pwsan.com>
@ 2007-05-08 21:01 ` Paul Walmsley
2007-05-08 21:40 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Paul Walmsley @ 2007-05-08 21:01 UTC (permalink / raw)
To: linux-omap-open-source
[-- Attachment #1: fix-ipt-idletimer.patch --]
[-- Type: text/plain, Size: 1600 bytes --]
Update net/ipv4/netfilter/ipt_IDLETIMER.c to compile after recent
changes to include/linux/netdevice.h (commit
4e9cac2ba437fcb093c7417b1cd91a77ebd1756a). Compile-tested only.
CC net/ipv4/netfilter/ipt_IDLETIMER.o
net/ipv4/netfilter/ipt_IDLETIMER.c: In function 'utimer_notifier_call':
net/ipv4/netfilter/ipt_IDLETIMER.c:189: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
net/ipv4/netfilter/ipt_IDLETIMER.c: In function 'utimer_fini':
net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: 'dev_base' undeclared (first use in this function)
net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: (Each undeclared identifier is reported only once
net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: for each function it appears in.)
net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: 'struct net_device' has no member named 'next'
make[3]: *** [net/ipv4/netfilter/ipt_IDLETIMER.o] Error 1
Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
net/ipv4/netfilter/ipt_IDLETIMER.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-omap-2.6/net/ipv4/netfilter/ipt_IDLETIMER.c
===================================================================
--- linux-omap-2.6.orig/net/ipv4/netfilter/ipt_IDLETIMER.c
+++ linux-omap-2.6/net/ipv4/netfilter/ipt_IDLETIMER.c
@@ -219,7 +219,7 @@ static void utimer_fini(void)
rtnl_lock();
unregister_netdevice_notifier(&utimer_notifier_block);
- for (dev = dev_base; dev; dev = dev->next)
+ for_each_netdev(dev)
utimer_notifier_call(&utimer_notifier_block,
NETDEV_DOWN, dev);
rtnl_unlock();
--
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] fix ipt_IDLETIMER.c compilation
2007-05-08 21:01 ` [PATCH] fix ipt_IDLETIMER.c compilation Paul Walmsley
@ 2007-05-08 21:40 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2007-05-08 21:40 UTC (permalink / raw)
To: Paul Walmsley; +Cc: linux-omap-open-source
* Paul Walmsley <paul@pwsan.com> [070508 14:03]:
> Update net/ipv4/netfilter/ipt_IDLETIMER.c to compile after recent
> changes to include/linux/netdevice.h (commit
> 4e9cac2ba437fcb093c7417b1cd91a77ebd1756a). Compile-tested only.
>
> CC net/ipv4/netfilter/ipt_IDLETIMER.o
> net/ipv4/netfilter/ipt_IDLETIMER.c: In function 'utimer_notifier_call':
> net/ipv4/netfilter/ipt_IDLETIMER.c:189: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result
> net/ipv4/netfilter/ipt_IDLETIMER.c: In function 'utimer_fini':
> net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: 'dev_base' undeclared (first use in this function)
> net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: (Each undeclared identifier is reported only once
> net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: for each function it appears in.)
> net/ipv4/netfilter/ipt_IDLETIMER.c:222: error: 'struct net_device' has no member named 'next'
> make[3]: *** [net/ipv4/netfilter/ipt_IDLETIMER.o] Error 1
>
>
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
>
> ---
> net/ipv4/netfilter/ipt_IDLETIMER.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-omap-2.6/net/ipv4/netfilter/ipt_IDLETIMER.c
> ===================================================================
> --- linux-omap-2.6.orig/net/ipv4/netfilter/ipt_IDLETIMER.c
> +++ linux-omap-2.6/net/ipv4/netfilter/ipt_IDLETIMER.c
> @@ -219,7 +219,7 @@ static void utimer_fini(void)
>
> rtnl_lock();
> unregister_netdevice_notifier(&utimer_notifier_block);
> - for (dev = dev_base; dev; dev = dev->next)
> + for_each_netdev(dev)
> utimer_notifier_call(&utimer_notifier_block,
> NETDEV_DOWN, dev);
> rtnl_unlock();
>
> --
Pushing this one too.
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-05-08 21:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20070508210138.371687586@pwsan.com>
2007-05-08 21:01 ` [PATCH] fix ipt_IDLETIMER.c compilation Paul Walmsley
2007-05-08 21:40 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.