From: Petr Baudis <pasky@ucw.cz>
To: Junio C Hamano <junkio@cox.net>
Cc: <git@vger.kernel.org>
Subject: [PATCH] gitweb: Do not use absolute font sizes
Date: Wed, 09 May 2007 03:41:50 +0200 [thread overview]
Message-ID: <20070509014150.7477.48489.stgit@rover> (raw)
In-Reply-To: <6efbd9b70705071613p23017509qaf9af12c1d14f9cb@mail.gmail.com>
Avoid specifying font sizes in pixels, since that is just pure evil.
Pointed out by Chris Riddoch.
Note that this is pretty much just a proposal; I didn't test if everything
fits perfectly right, but things seem to be pretty much okay. repo.or.cz
uses it now as a test drive - if you find any visual quirks, please point
them out, with a patch if possible since I'm total CSS noob and debugging
CSS is an extremely painful experience for me.
Note that this patch actually does change visual look of gitweb in Firefox
with my resolution and default settings - everything is bigger and I can't
explain the joy of actually seeing gitweb text that is in _readable_ size;
also, my horizontal screen real estate feels better used now. But judging
from the look of most modern webpages on the 'net, most people prefer
reading the web with strained eyes and/or a magnifying glass (I wonder what
species of scientists should look into this mystifying phenomenon) - so,
please tell us what you think.
Maybe we might want to get rid of absolute sizes other than font sizes in
the CSS file too in the long term.
Signed-off-by: Petr Baudis <pasky@suse.cz>
---
gitweb/gitweb.css | 19 +++++++++----------
1 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
index 6c662a1..df12d78 100644
--- a/gitweb/gitweb.css
+++ b/gitweb/gitweb.css
@@ -1,6 +1,5 @@
body {
font-family: sans-serif;
- font-size: 12px;
border: solid #d9d8d1;
border-width: 1px;
margin: 10px;
@@ -31,7 +30,7 @@ img.logo {
div.page_header {
height: 25px;
padding: 8px;
- font-size: 18px;
+ font-size: 150%;
font-weight: bold;
background-color: #d9d8d1;
}
@@ -113,7 +112,7 @@ span.signoff {
div.log_link {
padding: 0px 8px;
- font-size: 10px;
+ font-size: 70%;
font-family: sans-serif;
font-style: normal;
position: relative;
@@ -204,13 +203,13 @@ table.blame {
table.blame td {
padding: 0px 5px;
- font-size: 12px;
+ font-size: 100%;
vertical-align: top;
}
th {
padding: 2px 5px;
- font-size: 12px;
+ font-size: 100%;
text-align: left;
}
@@ -232,14 +231,14 @@ tr.dark:hover {
td {
padding: 2px 5px;
- font-size: 12px;
+ font-size: 100%;
vertical-align: top;
}
td.link, td.selflink {
padding: 2px 5px;
font-family: sans-serif;
- font-size: 10px;
+ font-size: 70%;
}
td.selflink {
@@ -416,7 +415,7 @@ div.index_include {
}
div.search {
- font-size: 12px;
+ font-size: 100%;
font-weight: normal;
margin: 4px 8px;
position: absolute;
@@ -444,7 +443,7 @@ a.rss_logo {
background-color: #ff6600;
font-weight: bold;
font-family: sans-serif;
- font-size: 10px;
+ font-size: 70%;
text-align: center;
text-decoration: none;
}
@@ -455,7 +454,7 @@ a.rss_logo:hover {
span.refs span {
padding: 0px 4px;
- font-size: 10px;
+ font-size: 70%;
font-weight: normal;
border: 1px solid;
background-color: #ffaaff;
next prev parent reply other threads:[~2007-05-09 2:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 23:13 gitweb css - pixels?! Chris Riddoch
2007-05-08 1:23 ` Allan Wind
2007-05-08 4:43 ` Chris Riddoch
2007-05-08 8:36 ` Jan Hudec
2007-05-09 1:41 ` Petr Baudis [this message]
2007-05-09 5:54 ` [PATCH] gitweb: Do not use absolute font sizes Junio C Hamano
2007-05-09 13:47 ` Petr Baudis
2007-05-09 6:48 ` Chris Riddoch
2007-05-14 16:53 ` Jakub Narebski
2007-05-15 1:06 ` David Kågedal
2007-05-15 15:09 ` Jan Hudec
2007-05-15 23:59 ` Jakub Narebski
2007-05-16 10:51 ` [PATCH] gitweb: Change base font size to "small" Jakub Narebski
2007-05-17 2:17 ` Petr Baudis
2007-05-17 4:07 ` Junio C Hamano
2007-05-17 8:31 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509014150.7477.48489.stgit@rover \
--to=pasky@ucw.cz \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.