From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: "Jan Hudec" <bulb@ucw.cz>,
"David Kågedal" <davidk@lysator.liu.se>,
"Petr Baudis" <pasky@suse.cz>
Subject: [PATCH] gitweb: Change base font size to "small"
Date: Wed, 16 May 2007 12:51:38 +0200 [thread overview]
Message-ID: <200705161251.38729.jnareb@gmail.com> (raw)
In-Reply-To: <20070515150912.GA3653@efreet.light.src>
Commit 63fcbe00a66d7cb7d8bce9a36120a19a809a33b8 by Peter "Pasky" Baudis
"gitweb: Do not use absolute font sizes"
made gitweb use default font size, the font size you have configured
your browser to use, as a basis; other font sizes are given as
percentage.
David Kågedal noticed problem with this approach: too many web sites
explicitly select extra small font sizes, which means that you have to
select a "standard" font size in your browser that is a bit larger
than one would actually like.
Additionally, as Jan Hudec noticed, gitweb should explicitely request
being somewhat smaller than normal, because it has good use for long
lines. Normally one would usually want to set font so large, that
more than ~120 characters won't fit on the screen, since otherwise
pages that don't use margins are simply unreadable. However gitweb
presents a table with several columns, so having wider line is OK for
it.
Jan Hudec proposed to use 'font-size: small' to take above issues into
account. This avoid using "brain-damaged" explicit-pixel sizes, while
taking into account nature of gitweb output.
Thanks to mentioned commit by Pasky we need to add 'font-size: small'
in only one place, for BODY element.
See the original messages:
Message-ID: <87odkmgaj5.fsf@morpheus.local>
Message-ID: <20070515150912.GA3653@efreet.light.src>
Proposed-by: Jan Hudec <bulb@ucw.cz>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
This is commit wich has commit message larger than patch itself, but
I think the explanation is as important as patch itself, perhaps even
more important.
gitweb/gitweb.css | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.css b/gitweb/gitweb.css
index b57c8be..02623cb 100644
--- a/gitweb/gitweb.css
+++ b/gitweb/gitweb.css
@@ -1,5 +1,6 @@
body {
font-family: sans-serif;
+ font-size: small;
border: solid #d9d8d1;
border-width: 1px;
margin: 10px;
--
1.5.1.4
next prev parent reply other threads:[~2007-05-16 21:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 23:13 gitweb css - pixels?! Chris Riddoch
2007-05-08 1:23 ` Allan Wind
2007-05-08 4:43 ` Chris Riddoch
2007-05-08 8:36 ` Jan Hudec
2007-05-09 1:41 ` [PATCH] gitweb: Do not use absolute font sizes Petr Baudis
2007-05-09 5:54 ` Junio C Hamano
2007-05-09 13:47 ` Petr Baudis
2007-05-09 6:48 ` Chris Riddoch
2007-05-14 16:53 ` Jakub Narebski
2007-05-15 1:06 ` David Kågedal
2007-05-15 15:09 ` Jan Hudec
2007-05-15 23:59 ` Jakub Narebski
2007-05-16 10:51 ` Jakub Narebski [this message]
2007-05-17 2:17 ` [PATCH] gitweb: Change base font size to "small" Petr Baudis
2007-05-17 4:07 ` Junio C Hamano
2007-05-17 8:31 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705161251.38729.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=bulb@ucw.cz \
--cc=davidk@lysator.liu.se \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.