From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@osdl.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: [uml-devel] [PATCH 5/6] UML - Monitor stack usage
Date: Wed, 9 May 2007 16:27:22 -0400 [thread overview]
Message-ID: <20070509202722.GA22464@c2.user-mode-linux.org> (raw)
In preparation for reducing stack size, add a machanism to see how
much of a kernel stack is used. This fills a new stack with 0x6b on
allocation and sees where the lowest non-0x6b byte is on process
exit. It keeps track of the lowest value and logs values as they get
lower.
The lowest values I've seen so far are ~1250 bytes remaining on i386
(with order 0 stacks) and ~2650 on x86_64 (order 1).
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
--
arch/um/Kconfig.debug | 8 ++++++++
arch/um/defconfig | 1 +
arch/um/kernel/process.c | 35 +++++++++++++++++++++++++++++++++++
include/asm-um/thread_info.h | 16 ++++++++++++++++
4 files changed, 60 insertions(+)
Index: linux-2.6.21-mm/arch/um/Kconfig.debug
===================================================================
--- linux-2.6.21-mm.orig/arch/um/Kconfig.debug 2007-05-09 14:34:39.000000000 -0400
+++ linux-2.6.21-mm/arch/um/Kconfig.debug 2007-05-09 14:36:10.000000000 -0400
@@ -47,4 +47,12 @@ config GCOV
If you're involved in UML kernel development and want to use gcov,
say Y. If you're unsure, say N.
+config STACK_USAGE
+ bool "Track kernel stack usage"
+ default N
+ help
+ Track the maximum kernel stack usage - this will look at each
+ kernel stack at process exit and log it if it's the deepest
+ stack seen so far.
+
endmenu
Index: linux-2.6.21-mm/arch/um/kernel/process.c
===================================================================
--- linux-2.6.21-mm.orig/arch/um/kernel/process.c 2007-05-09 14:34:39.000000000 -0400
+++ linux-2.6.21-mm/arch/um/kernel/process.c 2007-05-09 14:36:10.000000000 -0400
@@ -427,3 +427,38 @@ unsigned long arch_align_stack(unsigned
return sp & ~0xf;
}
#endif
+
+#ifdef CONFIG_STACK_USAGE
+
+static int lowest_to_date = THREAD_SIZE;
+
+void mark_stack(struct thread_info *stack)
+{
+ if(stack == NULL)
+ return;
+
+ memset(stack, 0x6b, THREAD_SIZE);
+}
+
+void check_stack_usage(struct thread_info *s)
+{
+ unsigned int *stack;
+ unsigned int *p, *end;
+ int left;
+
+ stack = (unsigned int *) (s + 1);
+ end = (unsigned int *) ((unsigned long) stack + THREAD_SIZE);
+ for(p = stack; p < end; p++){
+ if(*p != 0x6b6b6b6b){
+ left = (p - stack);
+ if(left < lowest_to_date){
+ printk("Greatest stack depth - %d bytes left\n",
+ left * sizeof(*p));
+ lowest_to_date = left;
+ }
+ return;
+ }
+ }
+}
+
+#endif
Index: linux-2.6.21-mm/include/asm-um/thread_info.h
===================================================================
--- linux-2.6.21-mm.orig/include/asm-um/thread_info.h 2007-05-09 14:34:39.000000000 -0400
+++ linux-2.6.21-mm/include/asm-um/thread_info.h 2007-05-09 14:36:10.000000000 -0400
@@ -52,6 +52,20 @@ static inline struct thread_info *curren
return ti;
}
+#ifdef CONFIG_STACK_USAGE
+
+extern void mark_stack(struct thread_info *stack);
+extern void check_stack_usage(struct thread_info *stack);
+
+#define alloc_thread_info(tsk) \
+ ({ struct thread_info *stack = kmalloc(THREAD_SIZE, GFP_KERNEL); \
+ mark_stack(stack); \
+ stack; \
+ })
+#define free_thread_info(ti) ({ check_stack_usage(ti) ; kfree(ti); })
+
+#else
+
/* thread information allocation */
#define alloc_thread_info(tsk) \
((struct thread_info *) kmalloc(THREAD_SIZE, GFP_KERNEL))
@@ -59,6 +73,8 @@ static inline struct thread_info *curren
#endif
+#endif
+
#define PREEMPT_ACTIVE 0x10000000
#define TIF_SYSCALL_TRACE 0 /* syscall trace active */
Index: linux-2.6.21-mm/arch/um/defconfig
===================================================================
--- linux-2.6.21-mm.orig/arch/um/defconfig 2007-05-09 14:42:04.000000000 -0400
+++ linux-2.6.21-mm/arch/um/defconfig 2007-05-09 14:42:59.000000000 -0400
@@ -527,3 +527,4 @@ CONFIG_FORCED_INLINING=y
# CONFIG_RCU_TORTURE_TEST is not set
# CONFIG_GPROF is not set
# CONFIG_GCOV is not set
+# CONFIG_STACK_USAGE is not set
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Dike <jdike@addtoit.com>
To: Andrew Morton <akpm@osdl.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: [PATCH 5/6] UML - Monitor stack usage
Date: Wed, 9 May 2007 16:27:22 -0400 [thread overview]
Message-ID: <20070509202722.GA22464@c2.user-mode-linux.org> (raw)
In preparation for reducing stack size, add a machanism to see how
much of a kernel stack is used. This fills a new stack with 0x6b on
allocation and sees where the lowest non-0x6b byte is on process
exit. It keeps track of the lowest value and logs values as they get
lower.
The lowest values I've seen so far are ~1250 bytes remaining on i386
(with order 0 stacks) and ~2650 on x86_64 (order 1).
Signed-off-by: Jeff Dike <jdike@linux.intel.com>
--
arch/um/Kconfig.debug | 8 ++++++++
arch/um/defconfig | 1 +
arch/um/kernel/process.c | 35 +++++++++++++++++++++++++++++++++++
include/asm-um/thread_info.h | 16 ++++++++++++++++
4 files changed, 60 insertions(+)
Index: linux-2.6.21-mm/arch/um/Kconfig.debug
===================================================================
--- linux-2.6.21-mm.orig/arch/um/Kconfig.debug 2007-05-09 14:34:39.000000000 -0400
+++ linux-2.6.21-mm/arch/um/Kconfig.debug 2007-05-09 14:36:10.000000000 -0400
@@ -47,4 +47,12 @@ config GCOV
If you're involved in UML kernel development and want to use gcov,
say Y. If you're unsure, say N.
+config STACK_USAGE
+ bool "Track kernel stack usage"
+ default N
+ help
+ Track the maximum kernel stack usage - this will look at each
+ kernel stack at process exit and log it if it's the deepest
+ stack seen so far.
+
endmenu
Index: linux-2.6.21-mm/arch/um/kernel/process.c
===================================================================
--- linux-2.6.21-mm.orig/arch/um/kernel/process.c 2007-05-09 14:34:39.000000000 -0400
+++ linux-2.6.21-mm/arch/um/kernel/process.c 2007-05-09 14:36:10.000000000 -0400
@@ -427,3 +427,38 @@ unsigned long arch_align_stack(unsigned
return sp & ~0xf;
}
#endif
+
+#ifdef CONFIG_STACK_USAGE
+
+static int lowest_to_date = THREAD_SIZE;
+
+void mark_stack(struct thread_info *stack)
+{
+ if(stack == NULL)
+ return;
+
+ memset(stack, 0x6b, THREAD_SIZE);
+}
+
+void check_stack_usage(struct thread_info *s)
+{
+ unsigned int *stack;
+ unsigned int *p, *end;
+ int left;
+
+ stack = (unsigned int *) (s + 1);
+ end = (unsigned int *) ((unsigned long) stack + THREAD_SIZE);
+ for(p = stack; p < end; p++){
+ if(*p != 0x6b6b6b6b){
+ left = (p - stack);
+ if(left < lowest_to_date){
+ printk("Greatest stack depth - %d bytes left\n",
+ left * sizeof(*p));
+ lowest_to_date = left;
+ }
+ return;
+ }
+ }
+}
+
+#endif
Index: linux-2.6.21-mm/include/asm-um/thread_info.h
===================================================================
--- linux-2.6.21-mm.orig/include/asm-um/thread_info.h 2007-05-09 14:34:39.000000000 -0400
+++ linux-2.6.21-mm/include/asm-um/thread_info.h 2007-05-09 14:36:10.000000000 -0400
@@ -52,6 +52,20 @@ static inline struct thread_info *curren
return ti;
}
+#ifdef CONFIG_STACK_USAGE
+
+extern void mark_stack(struct thread_info *stack);
+extern void check_stack_usage(struct thread_info *stack);
+
+#define alloc_thread_info(tsk) \
+ ({ struct thread_info *stack = kmalloc(THREAD_SIZE, GFP_KERNEL); \
+ mark_stack(stack); \
+ stack; \
+ })
+#define free_thread_info(ti) ({ check_stack_usage(ti) ; kfree(ti); })
+
+#else
+
/* thread information allocation */
#define alloc_thread_info(tsk) \
((struct thread_info *) kmalloc(THREAD_SIZE, GFP_KERNEL))
@@ -59,6 +73,8 @@ static inline struct thread_info *curren
#endif
+#endif
+
#define PREEMPT_ACTIVE 0x10000000
#define TIF_SYSCALL_TRACE 0 /* syscall trace active */
Index: linux-2.6.21-mm/arch/um/defconfig
===================================================================
--- linux-2.6.21-mm.orig/arch/um/defconfig 2007-05-09 14:42:04.000000000 -0400
+++ linux-2.6.21-mm/arch/um/defconfig 2007-05-09 14:42:59.000000000 -0400
@@ -527,3 +527,4 @@ CONFIG_FORCED_INLINING=y
# CONFIG_RCU_TORTURE_TEST is not set
# CONFIG_GPROF is not set
# CONFIG_GCOV is not set
+# CONFIG_STACK_USAGE is not set
next reply other threads:[~2007-05-09 20:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-09 20:27 Jeff Dike [this message]
2007-05-09 20:27 ` [PATCH 5/6] UML - Monitor stack usage Jeff Dike
2007-05-10 4:07 ` [uml-devel] " Andrew Morton
2007-05-10 4:07 ` Andrew Morton
2007-05-10 11:55 ` [uml-devel] " Jeff Dike
2007-05-10 11:55 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070509202722.GA22464@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.