From: David Miller <davem@davemloft.net>
To: benh@kernel.crashing.org
Cc: linuxppc-dev@ozlabs.org, akpm@linux-foundation.org,
rusty@rustcorp.com.au, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] Add hard_irq_disable()
Date: Thu, 10 May 2007 01:49:44 -0700 (PDT) [thread overview]
Message-ID: <20070510.014944.41634852.davem@davemloft.net> (raw)
In-Reply-To: <1178786505.14928.225.camel@localhost.localdomain>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Thu, 10 May 2007 18:41:45 +1000
>
> > > What about my comment layout style ? I've been using that forever ... Or
> > > do you mean I should use a function documentation style layout there ?
> >
> > /* This
> > * is
> > * wrong
> > */
> >
> > /*
> > * This
> > * is
> > * right
> > */
>
> Hrm... how bad are you about that one ? I must say I prefer my style :-)
I think the "wrong" one is right because screen real-estate matters.
In fact that's the one I use and enforce throughout the networking
and sparc ports.
I even hand edit out those empty comment lines in patches submitted
to me when I spot them.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: benh@kernel.crashing.org
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, rusty@rustcorp.com.au
Subject: Re: [PATCH 2/3] Add hard_irq_disable()
Date: Thu, 10 May 2007 01:49:44 -0700 (PDT) [thread overview]
Message-ID: <20070510.014944.41634852.davem@davemloft.net> (raw)
In-Reply-To: <1178786505.14928.225.camel@localhost.localdomain>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Thu, 10 May 2007 18:41:45 +1000
>
> > > What about my comment layout style ? I've been using that forever ... Or
> > > do you mean I should use a function documentation style layout there ?
> >
> > /* This
> > * is
> > * wrong
> > */
> >
> > /*
> > * This
> > * is
> > * right
> > */
>
> Hrm... how bad are you about that one ? I must say I prefer my style :-)
I think the "wrong" one is right because screen real-estate matters.
In fact that's the one I use and enforce throughout the networking
and sparc ports.
I even hand edit out those empty comment lines in patches submitted
to me when I spot them.
next prev parent reply other threads:[~2007-05-10 8:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 5:25 [PATCH 2/3] Add hard_irq_disable() Benjamin Herrenschmidt
2007-05-10 5:25 ` Benjamin Herrenschmidt
2007-05-10 5:41 ` Andrew Morton
2007-05-10 5:41 ` Andrew Morton
2007-05-10 6:35 ` Benjamin Herrenschmidt
2007-05-10 6:35 ` Benjamin Herrenschmidt
2007-05-10 7:35 ` Andrew Morton
2007-05-10 7:35 ` Andrew Morton
2007-05-10 8:41 ` Benjamin Herrenschmidt
2007-05-10 8:41 ` Benjamin Herrenschmidt
2007-05-10 8:49 ` David Miller [this message]
2007-05-10 8:49 ` David Miller
2007-05-10 8:50 ` Andrew Morton
2007-05-10 8:50 ` Andrew Morton
2007-05-10 8:53 ` David Miller
2007-05-10 8:53 ` David Miller
2007-05-10 9:29 ` Benjamin Herrenschmidt
2007-05-10 9:29 ` Benjamin Herrenschmidt
2007-05-10 11:01 ` Josh Boyer
2007-05-10 11:01 ` Josh Boyer
2007-05-10 6:45 ` Satyam Sharma
2007-05-10 6:45 ` Satyam Sharma
2007-05-10 7:21 ` Benjamin Herrenschmidt
2007-05-10 7:21 ` Benjamin Herrenschmidt
2007-05-10 7:54 ` Satyam Sharma
2007-05-10 7:54 ` Satyam Sharma
2007-05-10 8:46 ` Benjamin Herrenschmidt
2007-05-10 8:46 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070510.014944.41634852.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.