From: Joachim Fenkes <fenkes@de.ibm.com>
To: "LinuxPPC-Dev" <linuxppc-dev@ozlabs.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Christoph Raisch <raisch@de.ibm.com>,
OF-General <general@lists.openfabrics.org>,
Stefan Roscher <stefan.roscher@de.ibm.com>
Subject: Re: [PATCH 1/6] IB/ehca: Serialize hypervisor calls in ehca_register_mr()
Date: Thu, 10 May 2007 10:55:46 +0200 [thread overview]
Message-ID: <200705101055.46433.fenkes@de.ibm.com> (raw)
In-Reply-To: <200705091347.57470.fenkes@de.ibm.com>
On Wednesday 09 May 2007 13:47, Joachim Fenkes wrote:
> --- a/drivers/infiniband/hw/ehca/hcp_if.c
> +++ b/drivers/infiniband/hw/ehca/hcp_if.c
> @@ -154,7 +154,9 @@ static long ehca_plpar_hcall9(unsigned l
> unsigned long arg9)
> {
> long ret;
> - int i, sleep_msecs;
> + int i, sleep_msecs, lock_is_set =3D 0;
> + unsigned long flags;
> +
> =20
> ehca_gen_dbg("opcode=3D%lx arg1=3D%lx arg2=3D%lx arg3=3D%lx arg4=3D%lx "
> "arg5=3D%lx arg6=3D%lx arg7=3D%lx arg8=3D%lx arg9=3D%lx",
> @@ -162,10 +164,18 @@ static long ehca_plpar_hcall9(unsigned l
Whoops, that's one too many empty line...
Roland, when you apply this patch, could you apply the following patch on t=
op:
=2D-- a/drivers/infiniband/hw/ehca/hcp_if.c
+++ b/drivers/infiniband/hw/ehca/hcp_if.c
@@ -157,7 +157,6 @@ static long ehca_plpar_hcall9(unsigned l
int i, sleep_msecs, lock_is_set =3D 0;
unsigned long flags;
=2D
ehca_gen_dbg("opcode=3D%lx arg1=3D%lx arg2=3D%lx arg3=3D%lx arg4=3D=
%lx "
"arg5=3D%lx arg6=3D%lx arg7=3D%lx arg8=3D%lx arg9=3D%l=
x",
opcode, arg1, arg2, arg3, arg4, arg5, arg6, arg7,
Thanks!
Joachim
=2D-=20
Joachim Fenkes =A0-- =A0eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH =A0-- =A0Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 =A0-- =A071032 Boeblingen =A0-- =A0Germany
eMail: fenkes@de.ibm.com =A0-- =A0Phone: +49 7031 16 1239
WARNING: multiple messages have this Message-ID (diff)
From: Joachim Fenkes <fenkes@de.ibm.com>
To: "LinuxPPC-Dev" <linuxppc-dev@ozlabs.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"OF-General" <general@lists.openfabrics.org>,
Roland Dreier <rolandd@cisco.com>,
"Hoang-Nam Nguyen" <hnguyen@de.ibm.com>,
"Christoph Raisch" <raisch@de.ibm.com>,
"Stefan Roscher" <stefan.roscher@de.ibm.com>
Subject: Re: [PATCH 1/6] IB/ehca: Serialize hypervisor calls in ehca_register_mr()
Date: Thu, 10 May 2007 10:55:46 +0200 [thread overview]
Message-ID: <200705101055.46433.fenkes@de.ibm.com> (raw)
In-Reply-To: <200705091347.57470.fenkes@de.ibm.com>
On Wednesday 09 May 2007 13:47, Joachim Fenkes wrote:
> --- a/drivers/infiniband/hw/ehca/hcp_if.c
> +++ b/drivers/infiniband/hw/ehca/hcp_if.c
> @@ -154,7 +154,9 @@ static long ehca_plpar_hcall9(unsigned l
> unsigned long arg9)
> {
> long ret;
> - int i, sleep_msecs;
> + int i, sleep_msecs, lock_is_set = 0;
> + unsigned long flags;
> +
>
> ehca_gen_dbg("opcode=%lx arg1=%lx arg2=%lx arg3=%lx arg4=%lx "
> "arg5=%lx arg6=%lx arg7=%lx arg8=%lx arg9=%lx",
> @@ -162,10 +164,18 @@ static long ehca_plpar_hcall9(unsigned l
Whoops, that's one too many empty line...
Roland, when you apply this patch, could you apply the following patch on top:
--- a/drivers/infiniband/hw/ehca/hcp_if.c
+++ b/drivers/infiniband/hw/ehca/hcp_if.c
@@ -157,7 +157,6 @@ static long ehca_plpar_hcall9(unsigned l
int i, sleep_msecs, lock_is_set = 0;
unsigned long flags;
-
ehca_gen_dbg("opcode=%lx arg1=%lx arg2=%lx arg3=%lx arg4=%lx "
"arg5=%lx arg6=%lx arg7=%lx arg8=%lx arg9=%lx",
opcode, arg1, arg2, arg3, arg4, arg5, arg6, arg7,
Thanks!
Joachim
--
Joachim Fenkes -- eHCA Linux Driver Developer and Hardware Tamer
IBM Deutschland Entwicklung GmbH -- Dept. 3627 (I/O Firmware Dev. 2)
Schoenaicher Strasse 220 -- 71032 Boeblingen -- Germany
eMail: fenkes@de.ibm.com -- Phone: +49 7031 16 1239
next prev parent reply other threads:[~2007-05-10 8:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-09 11:47 [PATCH 1/6] IB/ehca: Serialize hypervisor calls in ehca_register_mr() Joachim Fenkes
2007-05-09 11:47 ` Joachim Fenkes
2007-05-10 3:03 ` Roland Dreier
2007-05-10 3:03 ` Roland Dreier
2007-05-10 8:55 ` Joachim Fenkes [this message]
2007-05-10 8:55 ` Joachim Fenkes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200705101055.46433.fenkes@de.ibm.com \
--to=fenkes@de.ibm.com \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=raisch@de.ibm.com \
--cc=stefan.roscher@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.